Release events. Finally release the dockable windows.

Author: Hosch250

RetailCoder.VBE/API/ParserState.cs

@@ -38,7 +38,7 @@ public interface IParserStateEvents
     [ComDefaultInterface(typeof(IParserState))]
     [ComSourceInterfaces(typeof(IParserStateEvents))]
     [EditorBrowsable(EditorBrowsableState.Always)]
-    public class ParserState : IParserState
+    public class ParserState : IParserState, IDisposable
     {
         private const string ClassId = "28754D11-10CC-45FD-9F6A-525A65412B7A";
         private const string ProgId = "Rubberduck.ParserState";
@@ -132,5 +132,10 @@ public Declaration[] UserDeclarations
             //[return: MarshalAs(UnmanagedType.SafeArray/*, SafeArraySubType = VarEnum.VT_VARIANT*/)]
             get { return _userDeclarations; }
         }
+
+        public void Dispose()
+        {
+            _state.StateChanged -= _state_StateChanged;
+        }
     }
 }

RetailCoder.VBE/Extension.cs

@@ -69,8 +69,13 @@ public void OnStartupComplete(ref Array custom)
 
         public void OnDisconnection(ext_DisconnectMode RemoveMode, ref Array custom)
         {
+            var addin = _kernel.Get<AddIn>();
+
             _app.Shutdown();
             _kernel.Dispose();
+
+            Marshal.FinalReleaseComObject(addin);
+            GC.SuppressFinalize(addin);
         }
     }
 }

RetailCoder.VBE/Navigation/CodeExplorer/CodeExplorerViewModel.cs

@@ -15,7 +15,7 @@
 
 namespace Rubberduck.Navigation.CodeExplorer
 {
-    public class CodeExplorerViewModel : ViewModelBase
+    public class CodeExplorerViewModel : ViewModelBase, IDisposable
     {
         private readonly FolderHelper _folderHelper;
         private readonly RubberduckParserState _state;
@@ -360,5 +360,11 @@ private void ExecuteRemoveComand(object param)
 
             _externalRemoveCommand.Execute(param);
         }
+
+        public void Dispose()
+        {
+            _state.StateChanged -= ParserState_StateChanged;
+            _state.ModuleStateChanged -= ParserState_ModuleStateChanged;
+        }
     }
 }

RetailCoder.VBE/UI/CodeInspections/InspectionResultsViewModel.cs

@@ -21,7 +21,7 @@
 
 namespace Rubberduck.UI.CodeInspections
 {
-    public class InspectionResultsViewModel : ViewModelBase, INavigateSelection
+    public class InspectionResultsViewModel : ViewModelBase, INavigateSelection, IDisposable
     {
         private readonly RubberduckParserState _state;
         private readonly IInspector _inspector;
@@ -341,5 +341,10 @@ private bool CanExecuteCopyResultsCommand(object parameter)
         {
             return !IsBusy && _results != null && _results.Any();
         }
+
+        public void Dispose()
+        {
+            _state.StateChanged -= _state_StateChanged;
+        }
     }
 }

RetailCoder.VBE/UI/Command/MenuItems/RubberduckCommandBar.cs

@@ -141,6 +141,8 @@ public void Dispose()
                 return;
             }
 
+            _state.StateChanged -= State_StateChanged;
+
             _refreshButton.Delete();
             _selectionButton.Delete();
             _statusButton.Delete();

RetailCoder.VBE/UI/DockableToolwindowPresenter.cs

@@ -116,11 +116,13 @@ protected virtual void Dispose(bool disposing)
             if (UserControl != null)
             {
                 UserControl.Dispose();
+                GC.SuppressFinalize(UserControl);
             }
 
             if (_window != null)
             {
-                Marshal.ReleaseComObject(_window);
+                _window.Close();
+                Marshal.FinalReleaseComObject(_window);
             }
         }
     }

RetailCoder.VBE/UI/SourceControl/SourceControlViewViewModel.cs

@@ -17,7 +17,7 @@
 
 namespace Rubberduck.UI.SourceControl
 {
-    public class SourceControlViewViewModel : ViewModelBase
+    public class SourceControlViewViewModel : ViewModelBase, IDisposable
     {
         private readonly VBE _vbe;
         private readonly RubberduckParserState _state;
@@ -559,5 +559,10 @@ public ICommand LoginGridCancelCommand
                 return _loginGridCancelCommand;
             }
         }
+
+        public void Dispose()
+        {
+            _state.StateChanged -= _state_StateChanged;
+        }
     }
 }

RetailCoder.VBE/UI/ToDoItems/ToDoExplorerViewModel.cs

@@ -13,7 +13,7 @@
 
 namespace Rubberduck.UI.ToDoItems
 {
-    public class ToDoExplorerViewModel : ViewModelBase, INavigateSelection
+    public class ToDoExplorerViewModel : ViewModelBase, INavigateSelection, IDisposable
     {
         private readonly RubberduckParserState _state;
         private readonly IGeneralConfigService _configService;
@@ -147,5 +147,10 @@ private IEnumerable<ToDoItem> GetItems()
         {
             return _state.AllComments.SelectMany(GetToDoMarkers);
         }
+
+        public void Dispose()
+        {
+            _state.StateChanged -= _state_StateChanged;
+        }
     }
 }

Rubberduck.Parsing/VBA/RubberduckParser.cs

@@ -20,7 +20,7 @@
 
 namespace Rubberduck.Parsing.VBA
 {
-    public class RubberduckParser : IRubberduckParser
+    public class RubberduckParser : IRubberduckParser, IDisposable
     {
         public RubberduckParserState State
         {
@@ -570,5 +570,22 @@ private void ResolveReferences(DeclarationFinder finder, VBComponent component,
             _state.SetModuleState(component, state);
             Debug.WriteLine("'{0}' is {1} (thread {2})", component.Name, _state.GetModuleState(component), Thread.CurrentThread.ManagedThreadId);
         }
+
+        public void Dispose()
+        {
+            State.ParseRequest -= ReparseRequested;
+            State.StateChanged -= StateOnStateChanged;
+
+            if (_resolverTokenSource != null)
+            {
+                _resolverTokenSource.Dispose();
+            }
+
+            if (_central != null)
+            {
+                _central.Cancel();
+                _central.Dispose();
+            }
+        }
     }
 }