Set up IoC registration to provide Default settings

Author: Vogel612

Rubberduck.Main/Extension.cs

@@ -149,12 +149,7 @@ private void InitializeAddIn()
                 }
 
                 var pathProvider = PersistencePathProvider.Instance;
-                var configLoader = new XmlPersistenceService<GeneralSettings>(pathProvider)
-                {
-                    FilePath =
-                        Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData),
-                            "Rubberduck", "rubberduck.config")
-                };
+                var configLoader = new XmlPersistenceService<GeneralSettings>(pathProvider);
                 var configProvider = new GeneralConfigProvider(configLoader);
 
                 _initialSettings = configProvider.Read();

Rubberduck.Main/Root/FixedGenericAppender.cs

@@ -0,0 +1,23 @@
+using Castle.Core;
+using Castle.MicroKernel.Context;
+using Castle.MicroKernel.Handlers;
+using System;
+using System.Linq;
+
+namespace Rubberduck.Root
+{
+    class FixedGenericAppender : IGenericImplementationMatchingStrategy
+    {
+        private readonly Type[] closingGenerics;
+
+        public FixedGenericAppender(Type[] closingGenerics)
+        {
+            this.closingGenerics = closingGenerics;
+        }
+
+        public Type[] GetGenericArguments(ComponentModel model, CreationContext context)
+        {
+            return context.GenericArguments.Union(closingGenerics).ToArray();
+        }
+    }
+}

Rubberduck.Main/Root/RubberduckIoCInstaller.cs

@@ -244,6 +244,11 @@ private void RegisterConfiguration(IWindsorContainer container, Assembly[] assem
                     .Where(t => Attribute.IsDefined(t, typeof(ExperimentalAttribute))));
             }
 
+            container.Register(Component.For(typeof(IDefaultSettings<>))
+                .ImplementedBy(typeof(DefaultSettings<,>), new FixedGenericAppender(new[] { typeof(Properties.Settings) }))
+                .IsFallback()
+                .LifestyleTransient());
+
             var provider = new ExperimentalTypesProvider(experimentalTypes);
             container.Register(Component.For(typeof(IExperimentalTypesProvider))
                 .DependsOn(Dependency.OnComponent<ViewModelBase, GeneralSettingsViewModel>())

RubberduckTests/Settings/GeneralSettingsTests.cs

@@ -168,13 +168,12 @@ public void AutoSavePeriodIsSetInCtor()
         public void UserSettingsLoadedUsingDefaultWhenMissingFile()
         {
             var pathProviderMock = new Mock<IPersistencePathProvider>();
-            pathProviderMock.Setup(x => x.DataRootPath).Returns("C:\\rubberduck\\");
+            pathProviderMock.Setup(x => x.DataRootPath).Returns(@"C:\some\non\existent\path\rubberduck");
             pathProviderMock.Setup(x => x.DataFolderPath(It.IsAny<string>())).Returns<string>(x => x);
             // For this test, we need to use the actual object. Fortunately, the path is virtual, so we
             // can override that property and force it to use an non-existent path to prove that settings
             // will be still created using defaults without the file present. 
             var persisterMock = new Mock<XmlPersistenceService<GeneralSettings>>(pathProviderMock.Object);
-            persisterMock.Setup(x => x.FilePath).Returns("C:\\some\\non\\existent\\path\\rubberduck");
             persisterMock.CallBase = true;
             var configProvider = new GeneralConfigProvider(persisterMock.Object);