Correct the ordering for the MemberAccessTypeBinding

Update SimpleNameTypeBinding to check for ambiguous matches and return a ResolutionFailedExpression

Author: bclothier

Rubberduck.Parsing/Binding/Bindings/MemberAccessTypeBinding.cs

@@ -73,11 +73,7 @@ private IBoundExpression ResolveLExpressionIsProject(IBoundExpression lExpressio
             IBoundExpression boundExpression = null;
             var referencedProject = lExpression.ReferencedDeclaration;
             bool lExpressionIsEnclosingProject = _project.Equals(referencedProject);
-            boundExpression = ResolveProject(lExpression, name);
-            if (boundExpression != null)
-            {
-                return boundExpression;
-            }
+            
             boundExpression = ResolveProceduralModule(lExpressionIsEnclosingProject, lExpression, name, referencedProject);
             if (boundExpression != null)
             {
@@ -98,6 +94,11 @@ private IBoundExpression ResolveLExpressionIsProject(IBoundExpression lExpressio
             {
                 return boundExpression;
             }
+            boundExpression = ResolveProject(lExpression, name);
+            if (boundExpression != null)
+            {
+                return boundExpression;
+            }
             return boundExpression;
         }
 

Rubberduck.Parsing/Binding/Bindings/SimpleNameTypeBinding.cs

@@ -1,4 +1,5 @@
-using Rubberduck.Parsing.Grammar;
+using System;
+using Rubberduck.Parsing.Grammar;
 using Rubberduck.Parsing.Symbols;
 
 namespace Rubberduck.Parsing.Binding
@@ -123,6 +124,13 @@ procedural module or class module contained in the enclosing project.
             */
             if (_declarationFinder.IsMatch(_project.ProjectName, name))
             {
+                // Ensure there is no ambiguous matches
+                var ambiguousClassModule = _declarationFinder.FindModuleEnclosingProjectWithoutEnclosingModule(_project, _module, name, DeclarationType.ClassModule);
+                if (ambiguousClassModule != null)
+                {
+                    // We have an indeterminate result... (normally a VBA compile error)
+                    return new ResolutionFailedExpression();
+                }
                 return new SimpleNameExpression(_project, ExpressionClassification.Project, _expression);
             }
             var referencedProject = _declarationFinder.FindReferencedProject(_project, name);

RubberduckTests/Symbols/DeclarationFinderTests.cs

@@ -716,7 +716,6 @@ End Sub
 
         [Test]
         [Category("Resolver")]
-        [Ignore("WIP until PR is finalized")]
         public void SameNameForProjectAndClass_ScopedDeclaration_ClassSelection()
         {
             var refEditClass = @"
@@ -761,7 +760,7 @@ End Sub
 
         [Test]
         [Category("Resolver")]
-        [Ignore("WIP until PR is finalized")]
+        [Ignore("The test should fail as this is a compile error; need to work out how to set state to ResolverError")]
         public void SameNameForProjectAndClassImplicit_ScopedDeclaration()
         {
             var refEditClass = @"