fixed default member logic

Author: retailcoder

Rubberduck.Inspections/VariableRequiresSetAssignmentEvaluator.cs

@@ -74,17 +74,9 @@ public static bool RequiresSetAssignment(IdentifierReference reference, Rubberdu
 
             if (isObjectVariable)
             {
-                // get the members of the returning type, a default member could make us lie otherwise
                 var classModule = declaration.AsTypeDeclaration as ClassModuleDeclaration;
-                if (HasParameterlessDefaultMember(classModule))
-                {
-                    // assigned declaration has a default parameterless member, which is legally being assigned here.
-                    // might be a good idea to flag that default member assignment though...
-                    return false;
-                }
-
-                // assign declaration is an object without a default parameterless (or with all parameters optional) member - LHS needs a 'Set' keyword.
-                return true;
+                // if assigned declaration is an object without a default parameterless (or with all parameters optional) member, LHS needs a 'Set' keyword.
+                return !HasParameterlessDefaultMember(classModule);
             }
 
             // assigned declaration is a variant. we need to know about the RHS of the assignment.
@@ -115,7 +107,7 @@ public static bool RequiresSetAssignment(IdentifierReference reference, Rubberdu
             if (lastRef?.Declaration.IsObject ?? false)
             {
                 // the last reference in the expression is referring to an object type
-                // return true *if* the object doesn't have a default member
+                // return true *if* the object doesn't have a parameterless default member
                 var typeDeclaration = lastRef.Declaration.AsTypeDeclaration as ClassModuleDeclaration;
                 return !HasParameterlessDefaultMember(typeDeclaration);
             }

Rubberduck.Parsing/ComReflection/ReferencedDeclarationsCollector.cs

@@ -142,7 +142,7 @@ public List<Declaration> LoadDeclarationsFromLibrary()
             {
                 var moduleName = new QualifiedModuleName(_referenceName, _path,
                     module.Type == DeclarationType.Enumeration || module.Type == DeclarationType.UserDefinedType
-                        ? string.Format("_{0}", module.Name)
+                        ? $"_{module.Name}"
                         : module.Name);
 
                 var declaration = CreateModuleDeclaration(module, moduleName, project, GetModuleAttributes(module));
@@ -235,8 +235,9 @@ private void CreateMemberDeclarations(IEnumerable<ComMember> members, QualifiedM
                     _declarations.AddRange(hasParams.Parameters);
                     memberTree.AddChildren(hasParams.Parameters);
                 }
-                var coClass = memberDeclaration as ClassModuleDeclaration;
-                if (coClass != null && item == defaultMember)
+
+                var coClass = declaration as ClassModuleDeclaration;
+                if (coClass != null && item.IsDefault)
                 {
                     coClass.DefaultMember = memberDeclaration;
                 }
@@ -292,7 +293,7 @@ private Declaration CreateMemberDeclaration(ComMember member, QualifiedModuleNam
                 case DeclarationType.PropertyLet:
                     return new PropertyLetDeclaration(member, parent, module, attributes);
                 default:
-                    throw new InvalidEnumArgumentException(string.Format("Unexpected DeclarationType {0} encountered.", member.Type));
+                    throw new InvalidEnumArgumentException($"Unexpected DeclarationType {member.Type} encountered.");
             }
         }