Merge pull request #5533 from MDoerner/EnhanceFunctionReturnValueDiscardedInspectionForBuiltInFunctions

Disable FunctionReturnValueDiscardedInspection for functions not defined in user code.

Author: retailcoder

Rubberduck.CodeAnalysis/Inspections/Concrete/FunctionReturnValueDiscardedInspection.cs

@@ -53,11 +53,12 @@ public FunctionReturnValueDiscardedInspection(IDeclarationFinderProvider declara
         protected override bool IsResultReference(IdentifierReference reference, DeclarationFinder finder)
         {
             return reference?.Declaration != null
-                && !reference.IsAssignment
-                && !reference.IsArrayAccess
-                && !reference.IsInnerRecursiveDefaultMemberAccess
-                && reference.Declaration.DeclarationType == DeclarationType.Function
-                && IsCalledAsProcedure(reference.Context);
+                   && reference.Declaration.IsUserDefined
+                   && !reference.IsAssignment
+                   && !reference.IsArrayAccess
+                   && !reference.IsInnerRecursiveDefaultMemberAccess
+                   && reference.Declaration.DeclarationType == DeclarationType.Function
+                   && IsCalledAsProcedure(reference.Context);
         }
 
         private static bool IsCalledAsProcedure(ParserRuleContext context)

RubberduckTests/Inspections/FunctionReturnValueDiscardedInspectionTests.cs

@@ -4,6 +4,7 @@
 using Rubberduck.CodeAnalysis.Inspections.Concrete;
 using Rubberduck.Parsing.VBA;
 using Rubberduck.VBEditor.SafeComWrappers;
+using RubberduckTests.Mocks;
 
 namespace RubberduckTests.Inspections
 {
@@ -308,8 +309,20 @@ Public Sub Dummy()
     MsgBox ""Test""
     Workbooks.Add
 End Sub
+
+Public Sub Baz()
+    Err.Raise -1, ""Foo"", ""Bar""
+End Sub
 ";
-            Assert.AreEqual(0, InspectionResultsForStandardModule(code).Count());
+            var vbe = new MockVbeBuilder()
+                .ProjectBuilder("TestProject", ProjectProtection.Unprotected)
+                .AddComponent("TestModule", ComponentType.StandardModule, code)
+                .AddReference(ReferenceLibrary.VBA)
+                .AddReference(ReferenceLibrary.Excel)
+                .AddProjectToVbeBuilder()
+                .Build()
+                .Object;
+            Assert.AreEqual(0, InspectionResults(vbe).Count());
         }
 
         [Test]