Skip to content

Commit 7cb09bf

Browse files
committed
Fixed quick-fix in ImplicitPublicMemberInspection.cs to only rewrite the signature line, using CodePane content, not ParseTree content; modified ImplicitPublicMemberInspectionTests.cs to add comments in the procedure body.
1 parent ac895ee commit 7cb09bf

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

RetailCoder.VBE/Inspections/ImplicitPublicMemberInspectionResult.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,16 +42,16 @@ public SpecifyExplicitPublicModifierQuickFix(ParserRuleContext context, Qualifie
4242

4343
public override void Fix()
4444
{
45-
var oldContent = Context.GetText();
46-
var newContent = Tokens.Public + ' ' + oldContent;
47-
4845
var selection = Context.GetSelection();
49-
5046
var module = Selection.QualifiedName.Component.CodeModule;
51-
var lines = module.get_Lines(selection.StartLine, selection.LineCount);
5247

53-
module.DeleteLines(selection.StartLine, selection.LineCount);
54-
module.InsertLines(selection.StartLine, newContent);
48+
var signatureLine = selection.StartLine;
49+
50+
var oldContent = module.get_Lines(signatureLine, 1);
51+
var newContent = Tokens.Public + ' ' + oldContent;
52+
53+
module.DeleteLines(signatureLine);
54+
module.InsertLines(signatureLine, newContent);
5555
}
5656
}
5757
}

RubberduckTests/Inspections/ImplicitPublicMemberInspectionTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,13 +145,13 @@ public void ImplicitPublicMember_QuickFixWorks()
145145
{
146146
const string inputCode =
147147
@"Sub Foo(ByVal arg1 as Integer)
148-
148+
'Just an inoffensive little comment
149149
150150
End Sub";
151151

152152
const string expectedCode =
153153
@"Public Sub Foo(ByVal arg1 as Integer)
154-
154+
'Just an inoffensive little comment
155155
156156
End Sub";
157157

0 commit comments

Comments
 (0)