Fix bug, add more remove tests

Author: Hosch250

RetailCoder.VBE/Refactorings/RemoveParameters/RemoveParametersRefactoring.cs

@@ -6,6 +6,7 @@
 using Rubberduck.Parsing;
 using Rubberduck.Parsing.Grammar;
 using Rubberduck.Parsing.Symbols;
+using Rubberduck.UI;
 using Rubberduck.VBA;
 using Rubberduck.VBEditor;
 
@@ -57,7 +58,7 @@ public void Refactor(Declaration target)
 
         public void QuickFix(VBProjectParseResult parseResult, QualifiedSelection selection)
         {
-            _model = new RemoveParametersModel(parseResult, selection, null);
+            _model = new RemoveParametersModel(parseResult, selection, new RubberduckMessageBox());
             var target = _model.Declarations.FindSelection(selection, new[] { DeclarationType.Parameter });
 
             // ReSharper disable once PossibleUnintendedReferenceComparison
@@ -67,7 +68,7 @@ public void QuickFix(VBProjectParseResult parseResult, QualifiedSelection select
 
         private void RemoveParameters()
         {
-            if (_model.TargetDeclaration == null) { throw new NullReferenceException("Parameter is null."); }
+            if (_model.TargetDeclaration == null) { throw new NullReferenceException("Parameter is null"); }
 
             AdjustReferences(_model.TargetDeclaration.References, _model.TargetDeclaration);
             AdjustSignatures();

RubberduckTests/Refactoring/RemoveParametersTests.cs

@@ -1129,6 +1129,64 @@ public void RemoveParams_RefactorDeclaration_FailsInvalidTarget()
             {
                 Assert.AreEqual("Invalid declaration type", e.Message);
             }
+
+            Assert.IsTrue(false);
+        }
+
+        [TestMethod]
+        public void RemoveParams_PresenterIsNull()
+        {
+            //Input
+            const string inputCode =
+@"Private Sub Foo()
+End Sub";
+
+            //Arrange
+            var project = SetupMockProject(inputCode);
+            var module = project.Object.VBComponents.Item(0).CodeModule;
+            var parseResult = new RubberduckParser().Parse(project.Object);
+
+            var editor = new Mock<IActiveCodePaneEditor>();
+            editor.Setup(e => e.GetSelection()).Returns((QualifiedSelection?)null);
+
+            var factory = new RemoveParametersPresenterFactory(editor.Object, null,
+                parseResult, null);
+
+            //act
+            var refactoring = new RemoveParametersRefactoring(factory);
+            refactoring.Refactor();
+
+            Assert.AreEqual(inputCode, module.Lines());
+        }
+
+        [TestMethod]
+        public void RemoveParams_ModelIsNull()
+        {
+            //Input
+            const string inputCode =
+@"Private Sub Foo()
+End Sub";
+            var selection = new Selection(1, 23, 1, 27); //startLine, startCol, endLine, endCol
+
+            //Arrange
+            var project = SetupMockProject(inputCode);
+            var module = project.Object.VBComponents.Item(0).CodeModule;
+            var parseResult = new RubberduckParser().Parse(project.Object);
+
+            var qualifiedSelection = GetQualifiedSelection(selection);
+
+            //Specify Param(s) to remove
+            var model = new RemoveParametersModel(parseResult, qualifiedSelection, null);
+
+            //SetupFactory
+            var factory = SetupFactory(model);
+
+            //Act
+            var refactoring = new RemoveParametersRefactoring(factory.Object);
+            refactoring.Refactor(qualifiedSelection);
+
+            //Assert
+            Assert.AreEqual(inputCode, module.Lines());
         }
 
         [TestMethod]