Default test methods to Private. Closes #4658

Author: comintern

Rubberduck.UnitTesting/CodeGeneration/TestCodeGeneratorStatics.cs

@@ -40,7 +40,7 @@ public partial class TestCodeGenerator
 
         private static string TestMethodTemplate =>
 $@"'@TestMethod(""{DefaultTestCategory}"")
-Public Sub {{0}}() {RenameTestTodoComment}
+Private Sub {{0}}() {RenameTestTodoComment}
     On Error GoTo {TestFailLabel}
     
     {ArrangeComment}
@@ -58,7 +58,7 @@ Exit Sub
 
         private static string TestMethodExpectedErrorTemplate =>
 $@"'@TestMethod(""{DefaultTestCategory}"")
-Public Sub {{0}}() {RenameTestTodoComment}
+Private Sub {{0}}() {RenameTestTodoComment}
     Const {ExpectedErrorConstant} As Long = 0 {ExpectedErrorTodoComment}
     On Error GoTo {TestFailLabel}
     
@@ -121,25 +121,25 @@ Option Private Module
 {{1}}
 
 '@ModuleInitialize
-Public Sub {ModuleInitializeMethod}()
+Private Sub {ModuleInitializeMethod}()
 {ModuleInitializeComment}
 {{2}}
 End Sub
 
 '@ModuleCleanup
-Public Sub {ModuleCleanupMethod}()
+Private Sub {ModuleCleanupMethod}()
     {ModuleCleanupComment}
     Set Assert = Nothing
     Set Fakes = Nothing
 End Sub
 
 '@TestInitialize
-Public Sub {TestInitializeMethod}()
+Private Sub {TestInitializeMethod}()
     {TestInitializeComment}
 End Sub
 
 '@TestCleanup
-Public Sub {TestCleanupMethod}()
+Private Sub {TestCleanupMethod}()
     {TestCleanupComment}
 End Sub";
     }

Rubberduck.UnitTesting/UnitTesting/TestDiscovery.cs

@@ -1,19 +1,17 @@
-using System;
-using System.Collections.Generic;
+using System.Collections.Generic;
 using System.Linq;
 using Rubberduck.Parsing;
 using Rubberduck.Parsing.Annotations;
 using Rubberduck.Parsing.Symbols;
 using Rubberduck.Parsing.VBA;
 using Rubberduck.VBEditor;
-using Rubberduck.VBEditor.ComManagement.TypeLibsAPI;
 using Rubberduck.VBEditor.Extensions;
 using Rubberduck.VBEditor.SafeComWrappers.Abstract;
 
 namespace Rubberduck.UnitTesting
 {
-    // FIXME make internal. Nobody outside of RD.UnitTesting needs this!
-    public static class TestDiscovery // todo: reimplement using state.DeclarationFinder
+    // FIXME make internal. Nobody outside of RD.UnitTesting needs this! 
+    public static class TestDiscovery // todo: reimplement using state.DeclarationFinder 
     {
         public static IEnumerable<TestMethod> GetAllTests(RubberduckParserState state)
         {
@@ -37,10 +35,9 @@ public static IEnumerable<TestMethod> GetTests(IVBE vbe, IVBComponent component,
 
         public static bool IsTestMethod(RubberduckParserState state, Declaration item)
         {
-            return !state.AllUserDeclarations.Any(
-                    d => d.DeclarationType == DeclarationType.Parameter && Equals(d.ParentScopeDeclaration, item)) &&
-                item.Accessibility == Accessibility.Public &&
-                item.Annotations.Any(a => a.AnnotationType == AnnotationType.TestMethod);
+            return !state.AllUserDeclarations.Any(d =>
+                       d.DeclarationType == DeclarationType.Parameter && Equals(d.ParentScopeDeclaration, item)) &&
+                   item.Annotations.Any(a => a.AnnotationType == AnnotationType.TestMethod);
         }
 
         public static IEnumerable<Declaration> FindModuleInitializeMethods(QualifiedModuleName module, RubberduckParserState state)