Updated string compares to include culture info

Author: BZngr

Rubberduck.CodeAnalysis/Inspections/Concrete/UnreachableCaseInspection/ParseTreeExpressionEvaluator.cs

@@ -386,17 +386,22 @@ private bool Like(string input, string pattern)
 
         private bool AreEqual(string lhs, string rhs)
         {
-            return string.Compare(lhs, rhs, !_isOptionCompareBinary, CultureInfo.InvariantCulture) == 0;
+            var compareOptions = _isOptionCompareBinary ? 
+                StringComparison.CurrentCulture | StringComparison.Ordinal 
+                : StringComparison.CurrentCulture | StringComparison.OrdinalIgnoreCase;
+            return String.Equals(lhs, rhs, compareOptions);
         }
 
         private bool IsLessThan(string lhs, string rhs)
         {
-            return string.Compare(lhs, rhs, !_isOptionCompareBinary, CultureInfo.InvariantCulture) < 0;
+            var compareOptions = _isOptionCompareBinary ? CompareOptions.None : CompareOptions.IgnoreCase;
+            return String.Compare(lhs, rhs, CultureInfo.CurrentCulture, compareOptions) < 0;
         }
 
         private bool IsGreaterThan(string lhs, string rhs)
         {
-            return string.Compare(lhs, rhs, !_isOptionCompareBinary, CultureInfo.InvariantCulture) > 0;
+            var compareOptions = _isOptionCompareBinary ? CompareOptions.None : CompareOptions.IgnoreCase;
+            return String.Compare(lhs, rhs, CultureInfo.CurrentCulture, compareOptions) > 0;
         }
 
         public static string ConvertLikePatternToRegexPattern(string likePattern)

RubberduckTests/Inspections/UnreachableCase/ParseTreeExpressionEvaluatorUnitTests.cs

@@ -547,11 +547,28 @@ public void ParseTreeValueExpressionEvaluator_LogicBinaryConstants(string operan
         [TestCase("10_>_11", "False")]
         [TestCase("10_>=_10", "True")]
         [TestCase("10_=>_10", "True")]
-        [TestCase("6.5_>_5.2", "True")]
+        [TestCase("6.5_>_5.2", "True")] //exercise decimal compares
+        [TestCase("6.5_>=_5.2", "True")]
+        [TestCase("6.5_=>_5.2", "True")]
+        [TestCase("6.5_<_5.2", "False")]
+        [TestCase("6.5_<=_5.2", "False")]
+        [TestCase("6.5_=<_5.2", "False")]
+        [TestCase("5.2_=<_5.2", "True")]
+        [TestCase("6.5_<>_5.2", "True")]
+        [TestCase("6.5_=_5.2", "False")]
         [TestCase("True_<_3", "True")]
         [TestCase("False_<_-2", "False")]
-        [Category("Inspections")]
-        public void ParseTreeValueExpressionEvaluator_RelationalOpConstants(string operands, string expected)
+        [TestCase("4.0E30_<_4.6E30", "True")] //exercise double compares
+        [TestCase("4.0E30_<=_4.6E30", "True")]
+        [TestCase("4.0E30_=<_4.6E30", "True")]
+        [TestCase("4.0E30_<>_4.6E30", "True")]
+        [TestCase("4.0E30_>=_4.6E30", "False")]
+        [TestCase("4.0E30_=>_4.6E30", "False")]
+        [TestCase("4.6E30_=>_4.6E30", "True")]
+        [TestCase("4.0E30_=_4.6E30", "False")]
+        [TestCase("4.0E30_=_4.0E30", "True")]
+        [Category("Inspections")]
+        public void ParseTreeValueExpressionEvaluator_RelationalOpConstantOperands(string operands, string expected)
         {
             GetBinaryOpValues(operands, out IParseTreeValue LHS, out IParseTreeValue RHS, out string opSymbol);
 

RubberduckTests/Inspections/UnreachableCase/UnreachableCaseInspectionTests.cs

@@ -2112,6 +2112,34 @@ End Select
             Assert.AreEqual(expectedMsg, actualMsg);
         }
 
+        [TestCase(@"Option Compare Binary", 1)]
+        [TestCase(@"Option Compare Text", 1)]
+        [Category("Inspections")]
+        public void UnreachableCaseInspection_StringCompares(string optionCompare, int unreachable)
+        {
+            string valueWithIgnorableChars = "Ani\u00ADmal";
+            string inputCode =
+$@"
+{optionCompare}
+
+Sub FirstSub(y As Boolean)
+
+Const s1 As String = ""animal""
+Const s2 As String = {valueWithIgnorableChars}
+
+Select Case y
+        Case s1 = s2    'Always false since we do not ignore the hyphen (""\u00AD"")
+            'OK
+        Case 10 > 2
+            'OK because first case is always false
+        Case 7 < 10
+            'Unreachable
+    End Select
+End Sub";
+            (string expectedMsg, string actualMsg) = CheckActualResultsEqualsExpected(inputCode, unreachable: unreachable);
+            Assert.AreEqual(expectedMsg, actualMsg);
+        }
+
         [Test]
         [Category("Inspections")]
         public void UnreachableCaseInspection_Ampersand()