Skip to content

Commit c18550a

Browse files
committed
Fix some Unit-Tests after Grammar changes
1 parent 22c706e commit c18550a

File tree

3 files changed

+30
-30
lines changed

3 files changed

+30
-30
lines changed

Rubberduck.Parsing/Grammar/VBAParser.g4

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -586,28 +586,28 @@ visibility : PRIVATE | PUBLIC | FRIEND | GLOBAL;
586586

587587
// 5.6 Expressions
588588
expression :
589-
// Literal Expression has to come before lExpression, otherwise it'll be classified as simple name expression instead.
590-
whiteSpace? LPAREN whiteSpace? expression whiteSpace? RPAREN # parenthesizedExpr
591-
| literalExpression # literalExpr
592-
| lExpression # lExpr
593-
| builtInType # builtInTypeExpr
594-
| TYPEOF whiteSpace expression # typeofexpr // To make the grammar SLL, the type-of-is-expression is actually the child of an IS relational op.
595-
| NEW whiteSpace expression # newExpr
596-
| expression whiteSpace? POW whiteSpace? expression # powOp
597-
| MINUS whiteSpace? expression # unaryMinusOp
598-
| expression whiteSpace? (MULT | DIV) whiteSpace? expression # multOp
599-
| expression whiteSpace? INTDIV whiteSpace? expression # intDivOp
600-
| expression whiteSpace? MOD whiteSpace? expression # modOp
601-
| expression whiteSpace? (PLUS | MINUS) whiteSpace? expression # addOp
602-
| expression whiteSpace? AMPERSAND whiteSpace? expression # concatOp
603-
| expression whiteSpace? (EQ | NEQ | LT | GT | LEQ | GEQ | LIKE | IS) whiteSpace? expression # relationalOp
604-
| NOT whiteSpace? expression # logicalNotOp
605-
| expression whiteSpace? AND whiteSpace? expression # logicalAndOp
606-
| expression whiteSpace? OR whiteSpace? expression # logicalOrOp
607-
| expression whiteSpace? XOR whiteSpace? expression # logicalXorOp
608-
| expression whiteSpace? EQV whiteSpace? expression # logicalEqvOp
609-
| expression whiteSpace? IMP whiteSpace? expression # logicalImpOp
610-
| HASH expression # markedFileNumberExpr // Added to support special forms such as Input(file1, #file1)
589+
// Literal Expression has to come before lExpression, otherwise it'll be classified as simple name expression instead.
590+
whiteSpace? LPAREN whiteSpace? expression whiteSpace? RPAREN # parenthesizedExpr
591+
| NEW whiteSpace expression # newExpr
592+
| expression whiteSpace? POW whiteSpace? expression # powOp
593+
| MINUS whiteSpace? expression # unaryMinusOp
594+
| expression whiteSpace? (MULT | DIV) whiteSpace? expression # multOp
595+
| expression whiteSpace? INTDIV whiteSpace? expression # intDivOp
596+
| expression whiteSpace? MOD whiteSpace? expression # modOp
597+
| expression whiteSpace? (PLUS | MINUS) whiteSpace? expression # addOp
598+
| expression whiteSpace? AMPERSAND whiteSpace? expression # concatOp
599+
| expression whiteSpace? (EQ | NEQ | LT | GT | LEQ | GEQ | LIKE | IS) whiteSpace? expression # relationalOp
600+
| NOT whiteSpace? expression # logicalNotOp
601+
| expression whiteSpace? AND whiteSpace? expression # logicalAndOp
602+
| expression whiteSpace? OR whiteSpace? expression # logicalOrOp
603+
| expression whiteSpace? XOR whiteSpace? expression # logicalXorOp
604+
| expression whiteSpace? EQV whiteSpace? expression # logicalEqvOp
605+
| expression whiteSpace? IMP whiteSpace? expression # logicalImpOp
606+
| literalExpression # literalExpr
607+
| lExpression # lExpr
608+
| builtInType # builtInTypeExpr
609+
| TYPEOF whiteSpace expression # typeofexpr // To make the grammar SLL, the type-of-is-expression is actually the child of an IS relational op.
610+
| HASH expression # markedFileNumberExpr // Added to support special forms such as Input(file1, #file1)
611611
;
612612

613613
// 5.6.5 Literal Expressions

RubberduckTests/Grammar/VBAParserTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ 20 Debug.Print 42
162162
30 End With
163163
End Sub
164164
";
165-
var result = Parse(code);
165+
var result = Parse(code, PredictionMode.Sll);
166166
AssertTree(result.Item1, result.Item2, "//statementLabelDefinition", matches => matches.Count == 3);
167167
AssertTree(result.Item1, result.Item2, "//withStmt");
168168
}
@@ -383,7 +383,7 @@ public void TestDefDirectiveSameDefDirectiveMultipleLetterSpec()
383383
public void TestDefDirectiveLetterRange()
384384
{
385385
string code = @"DefBool B-C: DefByte Y-X: DefInt I-J: DefLng L-M: DefLngLng N-O: DefLngPtr P-Q: DefCur C-D: DefSng G-H: DefDbl D-E: DefDate T-U: DefStr E-F: DefObj O-P: DefVar V-W";
386-
var parseResult = Parse(code);
386+
var parseResult = Parse(code, PredictionMode.Sll);
387387
AssertTree(parseResult.Item1, parseResult.Item2, "//letterRange", matches => matches.Count == 13);
388388
}
389389

@@ -1274,7 +1274,7 @@ public void TestSingleLineIfRealWorldExample3()
12741274
Sub Test()
12751275
If Not oP_Window Is Nothing Then If Not oP_Window.Visible Then Unload oP_Window: Set oP_Window = Nothing
12761276
End Sub";
1277-
var parseResult = Parse(code);
1277+
var parseResult = Parse(code, PredictionMode.Sll);
12781278
AssertTree(parseResult.Item1, parseResult.Item2, "//singleLineIfStmt", matches => matches.Count == 2);
12791279
}
12801280

@@ -1577,7 +1577,7 @@ If Not pFault Then
15771577
Debug.Print ""SecondO:""; ans(1)
15781578
End If
15791579
End Sub";
1580-
var parseResult = Parse(code);
1580+
var parseResult = Parse(code, PredictionMode.Sll);
15811581
AssertTree(parseResult.Item1, parseResult.Item2, "//debugPrintStmt", matches => matches.Count == 2);
15821582
}
15831583

RubberduckTests/QuickFixes/RestoreErrorHandlingQuickFixTests.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -167,14 +167,14 @@ On Error GoTo ErrorHandler
167167
On Error GoTo ErrorHandler1
168168
169169
Exit Sub
170-
ErrorHandler:
170+
ErrorHandler1:
171171
If Err.Number > 0 Then 'TODO: handle specific error
172172
Err.Clear
173173
Resume Next
174174
End If
175175
176176
Exit Sub
177-
ErrorHandler1:
177+
ErrorHandler:
178178
If Err.Number > 0 Then 'TODO: handle specific error
179179
Err.Clear
180180
Resume Next
@@ -217,14 +217,14 @@ On Error GoTo ErrorHandler2
217217
ErrorHandler1:
218218
219219
Exit Sub
220-
ErrorHandler:
220+
ErrorHandler2:
221221
If Err.Number > 0 Then 'TODO: handle specific error
222222
Err.Clear
223223
Resume Next
224224
End If
225225
226226
Exit Sub
227-
ErrorHandler2:
227+
ErrorHandler:
228228
If Err.Number > 0 Then 'TODO: handle specific error
229229
Err.Clear
230230
Resume Next

0 commit comments

Comments
 (0)