fixed bug with SelfAssignedDeclarationInspection

retailcoder · retailcoder · commit d7da07de94e4 · 2016-04-22T01:32:02.000-04:00
diff --git a/RetailCoder.VBE/Inspections/SelfAssignedDeclarationInspection.cs b/RetailCoder.VBE/Inspections/SelfAssignedDeclarationInspection.cs
@@ -39,9 +39,8 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
                     && declaration.IsTypeSpecified()
                     && !ValueTypes.Contains(declaration.AsTypeName)
                     && declaration.DeclarationType == DeclarationType.Variable
-                    && declaration.ParentScope == declaration.QualifiedName.QualifiedModuleName.ToString()
-                    && declaration.ParentDeclaration != null
-                    && declaration.ParentDeclaration.DeclarationType == DeclarationType.Class)
+                    && declaration.ParentScopeDeclaration != null
+                    && declaration.ParentScopeDeclaration.DeclarationType.HasFlag(DeclarationType.Member))
                 .Select(issue => new SelfAssignedDeclarationInspectionResult(this, issue));
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -39,9 +39,8 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()`
`39`	`39`	`&& declaration.IsTypeSpecified()`
`40`	`40`	`&& !ValueTypes.Contains(declaration.AsTypeName)`
`41`	`41`	`&& declaration.DeclarationType == DeclarationType.Variable`
`42`		`- && declaration.ParentScope == declaration.QualifiedName.QualifiedModuleName.ToString()`
`43`		`- && declaration.ParentDeclaration != null`
`44`		`- && declaration.ParentDeclaration.DeclarationType == DeclarationType.Class)`
	`42`	`+ && declaration.ParentScopeDeclaration != null`
	`43`	`+ && declaration.ParentScopeDeclaration.DeclarationType.HasFlag(DeclarationType.Member))`
`45`	`44`	`.Select(issue => new SelfAssignedDeclarationInspectionResult(this, issue));`
`46`	`45`	`}`
`47`	`46`	`}`