Update RemoveParametersRefactoring to use a separate Removal collection

This allows segregating UI concerns from Model Concerns.
Also fixes two failing unit-tests because of incorrect messageBox setup

Author: Vogel612

Rubberduck.Core/UI/Refactorings/RemoveParameters/RemoveParametersPresenter.cs

@@ -44,7 +44,7 @@ public RemoveParametersModel Show()
             {
                 return null;
             }
-            _model.Parameters = _view.ViewModel.Parameters.Where(m => m.IsRemoved).Select(vm => vm.ToModel()).ToList();
+            _model.RemoveParameters = _view.ViewModel.Parameters.Where(m => m.IsRemoved).Select(vm => vm.ToModel()).ToList();
             return _model;
         }
     }

Rubberduck.Refactorings/RemoveParameters/RemoveParametersModel.cs

@@ -16,7 +16,8 @@ public class RemoveParametersModel
         public IEnumerable<Declaration> Declarations { get; }
 
         public Declaration TargetDeclaration { get; private set; }
-        public List<Parameter> Parameters { get; set; }
+        public List<Parameter> Parameters { get; private set; }
+        public List<Parameter> RemoveParameters { get; set; }
 
         private readonly IMessageBox _messageBox;
 
@@ -43,6 +44,7 @@ private void LoadParameters()
             if (TargetDeclaration == null) { return; }
 
             Parameters = GetParameters().Select(arg => new Parameter(arg)).ToList();
+            RemoveParameters = new List<Parameter>();
 
             if (TargetDeclaration.DeclarationType == DeclarationType.PropertyLet ||
                 TargetDeclaration.DeclarationType == DeclarationType.PropertySet)
@@ -79,7 +81,7 @@ private Declaration PromptIfTargetImplementsInterface()
             var message = string.Format(RubberduckUI.Refactoring_TargetIsInterfaceMemberImplementation, declaration.IdentifierName, interfaceMember.ComponentName, interfaceMember.IdentifierName);
 
             var confirm = _messageBox.ConfirmYN(message, RubberduckUI.ReorderParamsDialog_TitleText);
-            return confirm ? null : interfaceMember;
+            return confirm ? interfaceMember : null;
         }
 
         private Declaration GetEvent()

Rubberduck.Refactorings/RemoveParameters/RemoveParametersRefactoring.cs

@@ -97,11 +97,10 @@ public void QuickFix(RubberduckParserState state, QualifiedSelection selection)
 
             if (target != null)
             {
-                _model.Parameters.Clear();
-                _model.Parameters.Add(target);
+                _model.RemoveParameters.Add(target);
             } else
             {
-                return; // FIXME is this equivalent to before?
+                return;
             }
             RemoveParameters();
         }
@@ -170,11 +169,11 @@ private void RemoveCallArguments(VBAParser.ArgumentListContext argList, Qualifie
             var args = argList.children.OfType<VBAParser.ArgumentContext>().ToList();
             for (var i = 0; i < _model.Parameters.Count; i++)
             {
-                // All parameters we keep are to be removed by definition
-                //if (!_model.Parameters[i].IsRemoved)
-                //{
-                //    continue;
-                //}
+                // only remove params from RemoveParameters
+                if (!_model.RemoveParameters.Contains(_model.Parameters[i]))
+                {
+                    continue;
+                }
 
                 if (_model.Parameters[i].IsParamArray)
                 {
@@ -264,9 +263,9 @@ private void RemoveSignatureParameters(Declaration target)
 
             var parameters = ((IParameterizedDeclaration) target).Parameters.OrderBy(o => o.Selection).ToList();
 
-            foreach (var remove in _model.Parameters)
+            foreach (var index in _model.RemoveParameters.Select(rem => _model.Parameters.IndexOf(rem)))
             {
-                rewriter.Remove(remove.Declaration);
+                rewriter.Remove(parameters[index]);
             }
 
             _rewriters.Add(rewriter);