Changes requested in review.

Author: comintern

Rubberduck.Core/UI/Command/MenuItems/CommandBars/SerializeProjectsCommandMenuItem.cs

@@ -11,21 +11,21 @@ namespace Rubberduck.UI.Command.MenuItems.CommandBars
 {
     public class SerializeProjectsCommandMenuItem : CommandMenuItemBase
     {
-        public SerializeProjectsCommandMenuItem(SerializeDeclarationsCommand command) : base(command)
+        public SerializeProjectsCommandMenuItem(SerializeProjectsCommand command) : base(command)
         {
         }
 
         public override Func<string> Caption { get { return () => "Serialize"; } }
         public override string Key => "SerializeProjects";
     }
 
-    public class SerializeDeclarationsCommand : CommandBase
+    public class SerializeProjectsCommand : CommandBase
     {
         private readonly RubberduckParserState _state;
         private readonly IComProjectSerializationProvider _serializationProvider;
         private readonly IComLibraryProvider _comLibraryProvider;
 
-        public SerializeDeclarationsCommand(RubberduckParserState state, IComProjectSerializationProvider serializationProvider, IComLibraryProvider comLibraryProvider) 
+        public SerializeProjectsCommand(RubberduckParserState state, IComProjectSerializationProvider serializationProvider, IComLibraryProvider comLibraryProvider) 
             : base(LogManager.GetCurrentClassLogger())
         {
             _state = state;
@@ -49,19 +49,24 @@ protected override void OnExecute(object parameter)
 
             foreach (var project in _state.ProjectsProvider.Projects().Select(proj => proj.Project))
             {
-                foreach (var reference in project.References.Select(lib => new ReferenceInfo(lib)))
+                using (var references = project.References)
                 {
-                    var library = _comLibraryProvider.LoadTypeLibrary(reference.FullPath);
-                    if (library == null)
+                    foreach (var reference in references)
                     {
-                        Logger.Warn($"Could not load library {reference.FullPath} for serialization.");
-                        continue;
-                    }
+                        var info = new ReferenceInfo(reference);
+                        reference.Dispose();
+                        var library = _comLibraryProvider.LoadTypeLibrary(info.FullPath);
+                        if (library == null)
+                        {
+                            Logger.Warn($"Could not load library {info.FullPath} for serialization.");
+                            continue;
+                        }
 
-                    var type = new ComProject(library, reference.FullPath);
-                    if (!toSerialize.ContainsKey(type.Guid))
-                    {
-                        toSerialize.Add(type.Guid, type);
+                        var type = new ComProject(library, info.FullPath);
+                        if (!toSerialize.ContainsKey(type.Guid))
+                        {
+                            toSerialize.Add(type.Guid, type);
+                        }                      
                     }
                 }
             }

Rubberduck.Parsing/ComReflection/LibraryReferencedDeclarationsCollector.cs

@@ -5,7 +5,7 @@
 
 namespace Rubberduck.Parsing.ComReflection
 {
-    public class LibraryReferencedDeclarationsCollector : ReferencedDeclarationsCollector
+    public class LibraryReferencedDeclarationsCollector : ReferencedDeclarationsCollectorBase
     {
         private readonly IComLibraryProvider _comLibraryProvider;
 

Rubberduck.Parsing/ComReflection/ReferencedDeclarationsCollector.cs

@@ -4,12 +4,11 @@
 using System.Linq;
 using System.Runtime.InteropServices.ComTypes;
 using Rubberduck.Parsing.Symbols;
-using Rubberduck.Parsing.VBA;
 using Rubberduck.VBEditor;
 
 namespace Rubberduck.Parsing.ComReflection
 {
-    public abstract class ReferencedDeclarationsCollector : IReferencedDeclarationsCollector
+    public abstract class ReferencedDeclarationsCollectorBase : IReferencedDeclarationsCollector
     {
         public abstract IReadOnlyCollection<Declaration> CollectedDeclarations(ReferenceInfo reference);
 

Rubberduck.Parsing/ComReflection/SerializedReferencedDeclarationsCollector.cs

@@ -4,7 +4,7 @@
 
 namespace Rubberduck.Parsing.ComReflection
 {
-    public class SerializedReferencedDeclarationsCollector : ReferencedDeclarationsCollector
+    public class SerializedReferencedDeclarationsCollector : ReferencedDeclarationsCollectorBase
     {
         private readonly IComProjectSerializationProvider _serializer;