fixed broken tests

retailcoder · retailcoder · commit e4456400865e · 2017-06-02T22:21:44.000-04:00
diff --git a/Rubberduck.Inspections/Concrete/MultilineParameterInspection.cs b/Rubberduck.Inspections/Concrete/MultilineParameterInspection.cs
@@ -17,11 +17,14 @@ namespace Rubberduck.Inspections.Concrete
     public sealed class MultilineParameterInspection : ParseTreeInspectionBase
     {
         public MultilineParameterInspection(RubberduckParserState state)
-            : base(state, CodeInspectionSeverity.Suggestion) { }
+            : base(state, CodeInspectionSeverity.Suggestion)
+        {
+            Listener = new ParameterListener();
+        }
 
         public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;
 
-        public override IInspectionListener Listener => new ParameterListener();
+        public override IInspectionListener Listener { get; }
 
         public override IEnumerable<IInspectionResult> GetInspectionResults()
         {
@@ -37,7 +40,9 @@ public override IEnumerable<IInspectionResult> GetInspectionResults()
 
         public class ParameterListener : VBAParserBaseListener, IInspectionListener
         {
-            private readonly List<QualifiedContext<ParserRuleContext>> _contexts = new List<QualifiedContext<ParserRuleContext>>();
+            private readonly List<QualifiedContext<ParserRuleContext>> _contexts
+                = new List<QualifiedContext<ParserRuleContext>>();
+
             public IReadOnlyList<QualifiedContext<ParserRuleContext>> Contexts => _contexts;
 
             public QualifiedModuleName CurrentModuleName { get; set; }
diff --git a/Rubberduck.Inspections/Concrete/ObsoleteCallStatementInspection.cs b/Rubberduck.Inspections/Concrete/ObsoleteCallStatementInspection.cs
@@ -15,10 +15,13 @@ namespace Rubberduck.Inspections.Concrete
     public sealed class ObsoleteCallStatementInspection : ParseTreeInspectionBase
     {
         public ObsoleteCallStatementInspection(RubberduckParserState state)
-            : base(state, CodeInspectionSeverity.Suggestion) { }
+            : base(state, CodeInspectionSeverity.Suggestion)
+        {
+            Listener = new ObsoleteCallStatementListener();
+        }
 
         public override CodeInspectionType InspectionType => CodeInspectionType.LanguageOpportunities;
-        public override IInspectionListener Listener => new ObsoleteCallStatementListener();
+        public override IInspectionListener Listener { get; }
 
         public override IEnumerable<IInspectionResult> GetInspectionResults()
         {
diff --git a/Rubberduck.Inspections/Concrete/ObsoleteCommentSyntaxInspection.cs b/Rubberduck.Inspections/Concrete/ObsoleteCommentSyntaxInspection.cs
@@ -14,10 +14,14 @@ namespace Rubberduck.Inspections.Concrete
 {
     public sealed class ObsoleteCommentSyntaxInspection : ParseTreeInspectionBase
     {
-        public ObsoleteCommentSyntaxInspection(RubberduckParserState state) : base(state, CodeInspectionSeverity.Suggestion) { }
+        public ObsoleteCommentSyntaxInspection(RubberduckParserState state)
+            : base(state, CodeInspectionSeverity.Suggestion)
+        {
+            Listener = new ObsoleteCommentSyntaxListener();
+        }
 
         public override CodeInspectionType InspectionType => CodeInspectionType.LanguageOpportunities;
-        public override IInspectionListener Listener => new ObsoleteCommentSyntaxListener();
+        public override IInspectionListener Listener { get; }
 
         public override IEnumerable<IInspectionResult> GetInspectionResults()
         {
diff --git a/Rubberduck.Inspections/Concrete/ObsoleteLetStatementInspection.cs b/Rubberduck.Inspections/Concrete/ObsoleteLetStatementInspection.cs
@@ -15,10 +15,13 @@ namespace Rubberduck.Inspections.Concrete
     public sealed class ObsoleteLetStatementInspection : ParseTreeInspectionBase
     {
         public ObsoleteLetStatementInspection(RubberduckParserState state)
-            : base(state, CodeInspectionSeverity.Suggestion) { }
+            : base(state, CodeInspectionSeverity.Suggestion)
+        {
+            Listener = new ObsoleteLetStatementListener();
+        }
 
         public override CodeInspectionType InspectionType => CodeInspectionType.LanguageOpportunities;
-        public override IInspectionListener Listener => new ObsoleteLetStatementListener();
+        public override IInspectionListener Listener { get; }
 
         public override IEnumerable<IInspectionResult> GetInspectionResults()
         {
diff --git a/Rubberduck.Inspections/Concrete/OptionBaseInspection.cs b/Rubberduck.Inspections/Concrete/OptionBaseInspection.cs
@@ -15,10 +15,13 @@ namespace Rubberduck.Inspections.Concrete
     public sealed class OptionBaseInspection : ParseTreeInspectionBase
     {
         public OptionBaseInspection(RubberduckParserState state)
-            : base(state, CodeInspectionSeverity.Hint) { }
+            : base(state, CodeInspectionSeverity.Hint)
+        {
+            Listener = new OptionBaseStatementListener();
+        }
 
         public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;
-        public override IInspectionListener Listener => new OptionBaseStatementListener();
+        public override IInspectionListener Listener { get; }
 
         public override IEnumerable<IInspectionResult> GetInspectionResults()
         {
diff --git a/Rubberduck.Inspections/Concrete/OptionExplicitInspection.cs b/Rubberduck.Inspections/Concrete/OptionExplicitInspection.cs
@@ -16,11 +16,14 @@ namespace Rubberduck.Inspections.Concrete
     public sealed class OptionExplicitInspection : ParseTreeInspectionBase
     {
         public OptionExplicitInspection(RubberduckParserState state)
-            : base(state, CodeInspectionSeverity.Error) { }
+            : base(state, CodeInspectionSeverity.Error)
+        {
+            Listener = new MissingOptionExplicitListener();
+        }
 
         public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
 
-        public override IInspectionListener Listener => new MissingOptionExplicitListener();
+        public override IInspectionListener Listener { get; }
 
         public override IEnumerable<IInspectionResult> GetInspectionResults()
         {
diff --git a/Rubberduck.Inspections/Concrete/ProcedureCanBeWrittenAsFunctionInspection.cs b/Rubberduck.Inspections/Concrete/ProcedureCanBeWrittenAsFunctionInspection.cs
@@ -20,10 +20,13 @@ public sealed class ProcedureCanBeWrittenAsFunctionInspection : ParseTreeInspect
         private static readonly Logger Logger = LogManager.GetCurrentClassLogger();
 
         public ProcedureCanBeWrittenAsFunctionInspection(RubberduckParserState state)
-            : base(state, CodeInspectionSeverity.Suggestion) { }
+            : base(state, CodeInspectionSeverity.Suggestion)
+        {
+            Listener = new SingleByRefParamArgListListener();
+        }
 
         public override CodeInspectionType InspectionType => CodeInspectionType.LanguageOpportunities;
-        public override IInspectionListener Listener => new SingleByRefParamArgListListener();
+        public override IInspectionListener Listener { get; }
 
         public override IEnumerable<IInspectionResult> GetInspectionResults()
         {
diff --git a/Rubberduck.Inspections/Concrete/RedundantOptionInspection.cs b/Rubberduck.Inspections/Concrete/RedundantOptionInspection.cs
@@ -15,13 +15,16 @@ namespace Rubberduck.Inspections.Concrete
     public sealed class RedundantOptionInspection : ParseTreeInspectionBase
     {
         public RedundantOptionInspection(RubberduckParserState state)
-            : base(state, CodeInspectionSeverity.Hint) { }
+            : base(state, CodeInspectionSeverity.Hint)
+        {
+            Listener = new RedundantModuleOptionListener();
+        }
 
         public override string Meta => InspectionsUI.RedundantOptionInspectionMeta;
         public override string Description => InspectionsUI.RedundantOptionInspectionName;
         public override CodeInspectionType InspectionType => CodeInspectionType.LanguageOpportunities;
 
-        public override IInspectionListener Listener => new RedundantModuleOptionListener();
+        public override IInspectionListener Listener { get; }
 
         public override IEnumerable<IInspectionResult> GetInspectionResults()
         {
diff --git a/Rubberduck.Inspections/Inspector.cs b/Rubberduck.Inspections/Inspector.cs
@@ -61,14 +61,21 @@ public async Task<IEnumerable<IInspectionResult>> FindIssuesAsync(RubberduckPars
                 }
 
                 state.OnStatusMessageUpdate(RubberduckUI.CodeInspections_Inspecting);
+                var allIssues = new ConcurrentBag<IInspectionResult>();
 
                 var config = _configService.LoadConfiguration();
                 UpdateInspectionSeverity(config);
 
-                var allIssues = new ConcurrentBag<IInspectionResult>();
-
-                var parseTreeInspections = _inspections.OfType<IParseTreeInspection>().ToArray();
+                var parseTreeInspections = _inspections
+                    .Where(inspection => inspection.Severity != CodeInspectionSeverity.DoNotShow)
+                    .OfType<IParseTreeInspection>()
+                    .ToArray();
 
+                foreach(var listener in parseTreeInspections.Select(inspection => inspection.Listener))
+                {
+                    listener.ClearContexts();
+                }
+                
                 // Prepare ParseTreeWalker based inspections
                 var passes = Enum.GetValues(typeof (ParsePass)).Cast<ParsePass>();
                 foreach (var parsePass in passes)
@@ -133,6 +140,11 @@ private void WalkTrees(CodeInspectionSettings settings, RubberduckParserState st
                     .Select(inspection => inspection.Listener)
                     .ToList();
 
+                if (!listeners.Any())
+                {
+                    return;
+                }
+
                 List<KeyValuePair<QualifiedModuleName, IParseTree>> trees;
                 switch (pass)
                 {
@@ -146,11 +158,6 @@ private void WalkTrees(CodeInspectionSettings settings, RubberduckParserState st
                         throw new ArgumentOutOfRangeException(nameof(pass), pass, null);
                 }
 
-                foreach (var listener in listeners)
-                {
-                    listener.ClearContexts();
-                }
-
                 foreach (var componentTreePair in trees)
                 {
                     foreach (var listener in listeners)

Original file line number	Diff line number	Diff line change
`@@ -15,10 +15,13 @@ namespace Rubberduck.Inspections.Concrete`
`15`	`15`	`public sealed class ObsoleteCallStatementInspection : ParseTreeInspectionBase`
`16`	`16`	`{`
`17`	`17`	`public ObsoleteCallStatementInspection(RubberduckParserState state)`
`18`		`- : base(state, CodeInspectionSeverity.Suggestion) { }`
	`18`	`+ : base(state, CodeInspectionSeverity.Suggestion)`
	`19`	`+ {`
	`20`	`+ Listener = new ObsoleteCallStatementListener();`
	`21`	`+ }`
`19`	`22`
`20`	`23`	`public override CodeInspectionType InspectionType => CodeInspectionType.LanguageOpportunities;`
`21`		`- public override IInspectionListener Listener => new ObsoleteCallStatementListener();`
	`24`	`+ public override IInspectionListener Listener { get; }`
`22`	`25`
`23`	`26`	`public override IEnumerable<IInspectionResult> GetInspectionResults()`
`24`	`27`	`{`
Original file line number	Diff line number	Diff line change
`@@ -14,10 +14,14 @@ namespace Rubberduck.Inspections.Concrete`
`14`	`14`	`{`
`15`	`15`	`public sealed class ObsoleteCommentSyntaxInspection : ParseTreeInspectionBase`
`16`	`16`	`{`
`17`		`- public ObsoleteCommentSyntaxInspection(RubberduckParserState state) : base(state, CodeInspectionSeverity.Suggestion) { }`
	`17`	`+ public ObsoleteCommentSyntaxInspection(RubberduckParserState state)`
	`18`	`+ : base(state, CodeInspectionSeverity.Suggestion)`
	`19`	`+ {`
	`20`	`+ Listener = new ObsoleteCommentSyntaxListener();`
	`21`	`+ }`
`18`	`22`
`19`	`23`	`public override CodeInspectionType InspectionType => CodeInspectionType.LanguageOpportunities;`
`20`		`- public override IInspectionListener Listener => new ObsoleteCommentSyntaxListener();`
	`24`	`+ public override IInspectionListener Listener { get; }`
`21`	`25`
`22`	`26`	`public override IEnumerable<IInspectionResult> GetInspectionResults()`
`23`	`27`	`{`
Original file line number	Diff line number	Diff line change
`@@ -16,11 +16,14 @@ namespace Rubberduck.Inspections.Concrete`
`16`	`16`	`public sealed class OptionExplicitInspection : ParseTreeInspectionBase`
`17`	`17`	`{`
`18`	`18`	`public OptionExplicitInspection(RubberduckParserState state)`
`19`		`- : base(state, CodeInspectionSeverity.Error) { }`
	`19`	`+ : base(state, CodeInspectionSeverity.Error)`
	`20`	`+ {`
	`21`	`+ Listener = new MissingOptionExplicitListener();`
	`22`	`+ }`
`20`	`23`
`21`	`24`	`public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;`
`22`	`25`
`23`		`- public override IInspectionListener Listener => new MissingOptionExplicitListener();`
	`26`	`+ public override IInspectionListener Listener { get; }`
`24`	`27`
`25`	`28`	`public override IEnumerable<IInspectionResult> GetInspectionResults()`
`26`	`29`	`{`