Merge pull request #2550 from retailcoder/next

MockVbeBuilder correctly loads serialized references

Author: retailcoder

RetailCoder.VBE/Inspections/HostSpecificExpressionInspection.cs

@@ -0,0 +1,28 @@
+using System.Collections.Generic;
+using System.Linq;
+using Rubberduck.Inspections.Abstract;
+using Rubberduck.Inspections.Resources;
+using Rubberduck.Inspections.Results;
+using Rubberduck.Parsing.Symbols;
+using Rubberduck.Parsing.VBA;
+
+namespace Rubberduck.Inspections
+{
+    public sealed class HostSpecificExpressionInspection : InspectionBase
+    {
+        public HostSpecificExpressionInspection(RubberduckParserState state)
+            : base(state)
+        {
+        }
+
+        public override string Meta { get { return InspectionsUI.HostSpecificExpressionInspectionMeta; } }
+        public override string Description { get { return InspectionsUI.HostSpecificExpressionInspectionName; } }
+        public override CodeInspectionType InspectionType { get { return CodeInspectionType.LanguageOpportunities; } }
+
+        public override IEnumerable<InspectionResultBase> GetInspectionResults()
+        {
+            return Declarations.Where(item => item.DeclarationType == DeclarationType.BracketedExpression)
+                .Select(item => new HostSpecificExpressionInspectionResult(this, item)).ToList();
+        }
+    }
+}

RetailCoder.VBE/Inspections/Resources/InspectionsUI.Designer.cs

@@ -625,4 +625,13 @@ If the parameter can be null, ignore this inspection result; passing a null valu
     <value>Member '{0}' is not declared on the interface for type '{1}'.</value>
     <comment>{0} Member used, {1} type being accessed.</comment>
   </data>
+  <data name="HostSpecificExpressionInspectionMeta" xml:space="preserve">
+    <value>Bracketed expressions are evaluated by the host application at runtime, which means VBA can't validate the expression at compile-time. Consider using the host application's object model instead.</value>
+  </data>
+  <data name="HostSpecificExpressionInspectionName" xml:space="preserve">
+    <value>Host-specific bracketed expression is only evaluated at runtime</value>
+  </data>
+  <data name="HostSpecificExpressionInspectionResultFormat" xml:space="preserve">
+    <value>Expression '{0}' cannot be validated at compile-time.</value>
+  </data>
 </root>

RetailCoder.VBE/Inspections/Resources/InspectionsUI.resx

@@ -0,0 +1,22 @@
+using Rubberduck.Inspections.Abstract;
+using Rubberduck.Inspections.Resources;
+using Rubberduck.Parsing.Symbols;
+
+namespace Rubberduck.Inspections.Results
+{
+    public class HostSpecificExpressionInspectionResult : InspectionResultBase
+    {
+        public HostSpecificExpressionInspectionResult(IInspection inspection, Declaration target)
+            : base(inspection, target)
+        {
+        }
+
+        public override string Description
+        {
+            get
+            {
+                return string.Format(InspectionsUI.HostSpecificExpressionInspectionResultFormat, Target.IdentifierName);
+            }
+        }
+    }
+}

RetailCoder.VBE/Inspections/Results/HostSpecificExpressionInspectionResult.cs

@@ -91,7 +91,7 @@ public override void Load()
             Bind<Func<IIndenterSettings>>().ToMethod(t => () => KernelInstance.Get<IGeneralConfigService>().LoadConfiguration().UserSettings.IndenterSettings);
 
             BindCustomDeclarationLoadersToParser();
-            Rebind<IParseCoordinator>().To<ParseCoordinator>().InSingletonScope();
+            Rebind<IParseCoordinator>().To<ParseCoordinator>().InSingletonScope().WithConstructorArgument("serializedDeclarationsPath", (string)null);
             Bind<Func<IVBAPreprocessor>>().ToMethod(p => () => new VBAPreprocessor(double.Parse(_vbe.Version, CultureInfo.InvariantCulture)));
 
             Rebind<ISearchResultsWindowViewModel>().To<SearchResultsWindowViewModel>().InSingletonScope();

RetailCoder.VBE/Root/RubberduckModule.cs

@@ -365,6 +365,7 @@
     <Compile Include="Common\WinAPI\WM.cs" />
     <Compile Include="Common\WindowsOperatingSystem.cs" />
     <Compile Include="Common\UndocumentedAttribute.cs" />
+    <Compile Include="Inspections\HostSpecificExpressionInspection.cs" />
     <Compile Include="Inspections\HungarianNotationInspection.cs" />
     <Compile Include="Inspections\ImplicitDefaultMemberAssignmentInspection.cs" />
     <Compile Include="Inspections\MemberNotOnInterfaceInspection.cs" />
@@ -375,6 +376,7 @@
       <DependentUpon>InspectionsUI.resx</DependentUpon>
     </Compile>
     <Compile Include="Inspections\Results\AggregateInspectionResult.cs" />
+    <Compile Include="Inspections\Results\HostSpecificExpressionInspectionResult.cs" />
     <Compile Include="Inspections\Results\ImplicitDefaultMemberAssignmentInspectionResult.cs" />
     <Compile Include="Inspections\QuickFixes\IntroduceLocalVariableQuickFix.cs" />
     <Compile Include="Inspections\QuickFixes\OptionExplicitQuickFix.cs" />