Plug leaks in code explorer

rubberduck-vba · Oct 24, 2018 · f1c9125 · f1c9125
1 parent 9c9fbc3
commit f1c9125
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/Rubberduck.Core/Navigation/CodeExplorer/CodeExplorerComponentViewModel.cs b/Rubberduck.Core/Navigation/CodeExplorer/CodeExplorerComponentViewModel.cs
@@ -68,8 +68,9 @@ public CodeExplorerComponentViewModel(CodeExplorerItemViewModel parent, Declarat
                         var component = _projectsProvider.Component(qualifiedModuleName);
                         string parenthesizedName;
                         using (var properties = component.Properties)
+                        using (var nameProperty = properties["Name"])
                         {
-                            parenthesizedName = properties["Name"].Value.ToString() ?? string.Empty;
+                            parenthesizedName = nameProperty.Value.ToString() ?? string.Empty;
                         }
 
                         if (ContainsBuiltinDocumentPropertiesProperty())
@@ -113,7 +114,16 @@ private bool ContainsBuiltinDocumentPropertiesProperty()
             var component = _projectsProvider.Component(Declaration.QualifiedName.QualifiedModuleName);
             using (var properties = component.Properties)
             {
-                return properties.Any(item => item.Name == "BuiltinDocumentProperties");
+                foreach (var property in properties)
+                using(property)
+                {
+                    if (property.Name == "BuiltinDocumentProperties")
+                    {
+                        return true;
+                    }
+                }
+
+                return false;
             }
         }