Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tk library and sample change. #295

Closed
wants to merge 3 commits into from
Closed

Tk library and sample change. #295

wants to merge 3 commits into from

Conversation

windwiny
Copy link

No description provided.

@zzak
Copy link
Member

zzak commented Apr 24, 2013

@windwiny Thanks for your contribution! I've committed your typo fix, and added your patch for further discussion as Bug #8319 so TK maintainer can review.

@zzak zzak closed this in c262fda Apr 24, 2013
evanphx pushed a commit that referenced this pull request Apr 24, 2013
@nagachika
merge revision(s) 40435:
8a4fa09 
	Typo by @windwiny [Fixes GH-295]


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@40446 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
@windwiny
Copy link
Author

This patch is fix sample bug

  1. ext/tk/sample/demos-en/floor2.rb and ext/tk/sample/demos-en/knightstour.rb , using Tk::Canvas.create .
  2. ext/tk/sample/demos-en/dialog1.rb , Tk.update run after eval_samplecode Dialog close may be throw nilClass.

tenderlove pushed a commit to tenderlove/ruby that referenced this pull request Jan 24, 2014
Typo by @windwiny [Fixes rubyGH-295]
f5a140e 
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@40435 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@windwiny @zzak