Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling HasChild ES bug #585

Closed
MrHash opened this issue Apr 15, 2014 · 1 comment · Fixed by #590
Closed

Handling HasChild ES bug #585

MrHash opened this issue Apr 15, 2014 · 1 comment · Fixed by #590

Comments

@MrHash
Copy link
Contributor

MrHash commented Apr 15, 2014

With regard to this bug, elastic/elasticsearch#5783 which may take some time to be fixed and released, is it acceptable to switch the order of the HasChild query/filter contructor to set the type before the query? (see https://github.com/ruflin/Elastica/blob/master/lib/Elastica/Filter/HasChild.php#L28) I don't imagine there would be any BC issues
@ruflin
Copy link
Owner

ruflin commented Apr 19, 2014

Agree, we should change the order. Can you open a pull request with this and also an integration test with the example in elastic/elasticsearch#5783. Like this we make sure it doesn't break again.

@MrHash MrHash mentioned this issue Apr 20, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handling HasChild ES bug
2 participants
@ruflin @MrHash