Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for color picker in css`` blocks #320

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds support for color picker in css`` blocks #320

wants to merge 1 commit into from

Conversation

au5ton
Copy link

@au5ton au5ton commented Sep 5, 2023 •
edited

This adds support for CSS colors in the following formats:

  • rgb(...)
  • rgba(...)
  • hsl(...)
  • hsla(...)

I also added some rudimentary tests for the color provider as a result of these changes.

Fixes #319

@au5ton
Copy link
Author

au5ton commented Sep 11, 2023

@runem What do you think? Is there anything I can do to improve this before it can be accepted?

@au5ton au5ton changed the title Fixes #319 Adds support for color picker in css`` blocks Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[vscode-lit-plugin] Non-hex color formats aren't recognized for color picker
1 participant
@au5ton