-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting directive to undefined #342
Comments
nmattia
added a commit
to dfinity/internet-identity
that referenced
this issue
Jan 8, 2024
This adds a lit-analyzer lint check. This ensures we make correct use of lit templates. We disable three rules which currently appear to be overrestrictive: * runem/lit-analyzer#341 * runem/lit-analyzer#342 * runem/lit-analyzer#343
nmattia
added a commit
to dfinity/internet-identity
that referenced
this issue
Jan 8, 2024
This adds a lit-analyzer lint check. This ensures we make correct use of lit templates. We disable three rules which currently appear to be overrestrictive: * runem/lit-analyzer#341 * runem/lit-analyzer#342 * runem/lit-analyzer#343
github-merge-queue bot
pushed a commit
to dfinity/internet-identity
that referenced
this issue
Jan 8, 2024
This adds a lit-analyzer lint check. This ensures we make correct use of lit templates. We disable three rules which currently appear to be overrestrictive: * runem/lit-analyzer#341 * runem/lit-analyzer#342 * runem/lit-analyzer#343
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I often set a directive as potentially undefined:
lit-analyzer
flags this as incorrect:is this use case really incorrect? In practice it seems that
lit
is happy with it and just drops the directive. This is much simpler than e.g. writing two differenthgroup
s above (with only the directive being different between the two) and using one or the other.The text was updated successfully, but these errors were encountered: