Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate KIL representation #4051

Open
gtrepta opened this issue Feb 27, 2024 · 5 comments
Open

Investigate KIL representation #4051

gtrepta opened this issue Feb 27, 2024 · 5 comments

Comments

@gtrepta
Copy link
Contributor

gtrepta commented Feb 27, 2024

Right now we parse definitions into KIL and then transform them into the kore structures. Is KIL still necessary?

@Baltoli
Copy link
Collaborator

Baltoli commented Feb 27, 2024

@dwightguth: this is ancient code, and the compiler used to operate over this. The plan previously was to migrate the outer parser to generating this directly, rather than doing what we do currently. Ought to be possible to remove the KIL, but would need to match up the KIL structures with the "KORE" ones

@Baltoli
Copy link
Collaborator

Baltoli commented Feb 27, 2024

There may be tweaks needed here and there to get things working properly.

@Baltoli
Copy link
Collaborator

Baltoli commented Feb 27, 2024

kompile -E relies on the KIL structures to do pretty-printing; will need to change the "KORE" data structures to make sure that this behaviour is maintained.

@gtrepta
Copy link
Contributor Author

gtrepta commented Mar 7, 2024

One path to eliminating KIL could possibly be to allow pyk to do the outer parsing, after more integrations are done with #4066 and some functionality is added for the pipeline experiments

@Baltoli
Copy link
Collaborator

Baltoli commented Mar 12, 2024

That seems like a reasonable approach to take; removing KIL from the existing frontend doesn't quite entail a full rewrite of the outer parser, but it's getting in that direction. Given that we want to be doing this with Pyk anyway, we may as well wait and just eliminate the frontend outer parser entirely in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants