Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add listener support to WindowsSettings #51

Open
russhwolf opened this issue Apr 26, 2020 · 2 comments
Open

Add listener support to WindowsSettings #51

russhwolf opened this issue Apr 26, 2020 · 2 comments

Comments

@russhwolf
Copy link
Owner

Probably using RegNotifyChangeKeyValue. It may take some effort to massage the Windows API to fit the pattern used on other platforms.

@russhwolf
Copy link
Owner Author

I've started prototyping stuff here. I've tried an implementation where each listener gets its own worker, which seems to work alright but I worry it might get heavy if someone tries setting lots of listeners, and it had some flakiness when I tried to load-test it. I think I want to look into an alternative where listeners all run on a single dedicated worker, but that gets more complicated to implement. Given timing and where the ecosystem is, there's a good chance this ends up being built in a way that only supports the new memory manager.

Ideas and contributions welcome.

@russhwolf
Copy link
Owner Author

This is the last thing I would like to have done before removing @ExperimentalSettingsImplementation from RegistrySettings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant