Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -lmingwex second time in mingw_libs #124233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Apr 21, 2024

Upcoming mingw-w64 releases will contain small math functions refactor which moved implementation around. As a result functions like lgamma
now depend on libraries in this order:
libmingwex.a -> libmsvcrt.a -> libmingwex.a.

Fixes #124221

Upcoming mingw-w64 releases will contain small math functions refactor which moved implementation around.
As a result functions like `lgamma`
now depend on libraries in this order:
`libmingwex.a` -> `libmsvcrt.a` -> `libmingwex.a`.

Fixes rust-lang#124221
@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2024

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 21, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2024

These commits modify compiler targets.
(See the Target Tier Policy.)

@ChrisDenton
Copy link
Contributor

Would it be possible to use --start-group and --end-group? I fear otherwise we may be having to do something like this again and again.

@mati865
Copy link
Contributor Author

mati865 commented Apr 21, 2024

In the long run that would be better solution but it was discussed 2 or 3 years ago but nothing has happened since then.

@ChrisDenton
Copy link
Contributor

Right but this code looks like it is just setting linker arguments directly, no? So couldn't it just add the group manually for these libs?

@mati865
Copy link
Contributor Author

mati865 commented Apr 22, 2024

Yes, it should work, but I don't know if it's okay to do it. Previous talks were about a more generic solution.

@Nilstrieb
Copy link
Member

I'd say set it and see what happens^^. More generic solutions would always be good but no reason to block using it here over them (unless there is a very good reason). cc @petrochenkov

@petrochenkov petrochenkov self-assigned this Apr 22, 2024
@nnethercote nnethercote removed their assignment Apr 22, 2024
@nnethercote
Copy link
Contributor

I will defer to @petrochenkov here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Future version of mingw-w64 breaks externally linking some math functions
6 participants