Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

called Result::unwrap() on an Err value: failed while formatting fluent string codegen_ssa_unable_to_run_dsymutil #124392

Closed
glandium opened this issue Apr 26, 2024 · 0 comments · Fixed by #124414
Closed

called Result::unwrap() on an Err value: failed while formatting fluent string codegen_ssa_unable_to_run_dsymutil #124392

glandium opened this issue Apr 26, 2024 · 0 comments · Fixed by #124414
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-bug Category: This is a bug. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@glandium
Copy link
Contributor

When building a binary for mac and dsymutil is not in $PATH for whatever reason, this is the message that appears, followed by a backtrace, instead of the intended error:

thread 'rustc' panicked at compiler/rustc_errors/src/emitter.rs:1289:80:
called `Result::unwrap()` on an `Err` value: failed while formatting fluent string `codegen_ssa_unable_to_run_dsymutil`: 
the attribute `note` was missing
help: add `.note = <message>`

Indeed there is no note in the fluent file.

rust/compiler/rustc_codegen_ssa/messages.ftl

Lines 314 to 315 in 3a36386

codegen_ssa_unable_to_run_dsymutil = unable to run `dsymutil`: {$error}

while one is expected from the error declaration.

rust/compiler/rustc_codegen_ssa/src/errors.rs

Lines 432 to 434 in 3a36386

#[derive(Diagnostic)]
#[diag(codegen_ssa_unable_to_run_dsymutil)]
#[note]

@glandium glandium added C-bug Category: This is a bug. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 26, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 26, 2024
@lqd lqd mentioned this issue Apr 26, 2024
Merged
@lqd lqd added A-diagnostics Area: Messages for errors, warnings, and lints and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Apr 26, 2024
fmease added a commit to fmease/rust that referenced this issue May 2, 2024
@fmease
Rollup merge of rust-lang#124414 - lqd:subdiagnostics, r=davidtwco
811a27f 
remove extraneous note on `UnableToRunDsymutil` diagnostic

If I understand [this FIXME](https://github.com/rust-lang/rust/blob/1367827eac3d813a261a4c444037af9736996daa/compiler/rustc_macros/src/diagnostics/diagnostic.rs#L205) correctly, it seems we don't yet validate subdiagnostics, so `#[note]` and co in the `#[derive(Diagnostic]` item could be out-of-sync with the fluent message, without causing compile errors.

It was the case for `rustc_codegen_ssa::errors::UnableToRunDsymutil`, causing the ICE in rust-lang#124392.

I've grepped and scripted my way through most of our diagnostics structs and fluent bundles and the above was the only such extraneous `#[note]`/`#[note(name)]`/`#[help]`/`#[warning]` I could find, so hopefully there aren't many others like it.

I haven't checked if the opposite can happen, a `.note = ` in a fluent message that is lacking a corresponding `#[note]` on the struct and not causing an error, but maybe it's possible?

r? `@davidtwco`
fixes rust-lang#124392
@bors bors closed this as completed in e9e2ebb May 2, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue May 2, 2024
@rust-timer
Unrolled build for rust-lang#124414
aaa9d58 
Rollup merge of rust-lang#124414 - lqd:subdiagnostics, r=davidtwco

remove extraneous note on `UnableToRunDsymutil` diagnostic

If I understand [this FIXME](https://github.com/rust-lang/rust/blob/1367827eac3d813a261a4c444037af9736996daa/compiler/rustc_macros/src/diagnostics/diagnostic.rs#L205) correctly, it seems we don't yet validate subdiagnostics, so `#[note]` and co in the `#[derive(Diagnostic]` item could be out-of-sync with the fluent message, without causing compile errors.

It was the case for `rustc_codegen_ssa::errors::UnableToRunDsymutil`, causing the ICE in rust-lang#124392.

I've grepped and scripted my way through most of our diagnostics structs and fluent bundles and the above was the only such extraneous `#[note]`/`#[note(name)]`/`#[help]`/`#[warning]` I could find, so hopefully there aren't many others like it.

I haven't checked if the opposite can happen, a `.note = ` in a fluent message that is lacking a corresponding `#[note]` on the struct and not causing an error, but maybe it's possible?

r? ``@davidtwco``
fixes rust-lang#124392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-bug Category: This is a bug. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove extraneous note on UnableToRunDsymutil diagnostic lqd/rust
3 participants
@lqd @glandium @rustbot