Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Typescript definition files do not follow other components #3011

Closed
wants to merge 1 commit into from
Closed

Fix: Typescript definition files do not follow other components #3011

wants to merge 1 commit into from

Conversation

dlferro
Copy link
Collaborator

@dlferro dlferro commented Mar 3, 2022

Fixes #3010

Additional description

Let me know if I'm off on this, but I believe these should be in the root component directory.


CONTRIBUTOR checklist (do not remove)

Please complete for every pull request

  • First-time contributors should sign the Contributor License Agreement. It's a fancy way of saying that you are giving away your contribution to this project. If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
  • npm run lint:fix has been run and linting passes.
  • Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
  • Tests have been added for new props to prevent regressions in the future. See readme.
  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

  • CircleCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
  • Tests have been added for new props to prevent regressions in the future. See readme.
  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at DOM snapshot strings.
Required only if there are markup / UX changes
  • Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
  • Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
  • Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
  • While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

Moved type files to root components directory to align to other components and refactored module name for each.
@dlferro dlferro changed the title Incorrect type file locations. Fix: Typescript definition files do not follow other components Mar 9, 2022
@interactivellama
Copy link
Contributor

There are HoC wrappers around these components. What kind of issues are you having? Is the auto-complete not working?

@dlferro
Copy link
Collaborator Author

dlferro commented Jun 1, 2022

It's been a while since I've tried, but at the time it wasn't resolving the typings properly and enabling auto-complete.

@sfdc-qbranch sfdc-qbranch closed this by deleting the head repository Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type files out of place
3 participants