Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace shortid with nanoid #3134

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Replace shortid with nanoid #3134

wants to merge 4 commits into from

Conversation

lkretzschmar
Copy link

Fixes #3133

Additional description

Replaced shortid with nanoid

CONTRIBUTOR checklist (do not remove)

Please complete for every pull request

  • First-time contributors should sign the Contributor License Agreement. It's a fancy way of saying that you are giving away your contribution to this project. If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
  • npm run lint:fix has been run and linting passes.
  • Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test). (pre-existing code, last edited 5 years ago)
  • N/A Tests have been added for new props to prevent regressions in the future. See readme.
  • N/A Review the appropriate Storybook stories. Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/. (2 pre-existing failures)
  • N/A Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

  • CircleCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
  • Tests have been added for new props to prevent regressions in the future. See readme.
  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at DOM snapshot strings.
Required only if there are markup / UX changes
  • Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
  • Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
  • Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
  • While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

@welcome Welcome
Copy link

welcome bot commented Nov 17, 2023

Thanks for opening this pull request! 💯

This is a community-driven project, and we can't do it without your participation. Please check out our contributing guidelines and review the Contributor Checklist if you haven't already, to make sure everything is squared away. CircleCI will take about 10 minutes to run through the same items that are on the Contributor checklist with a pass/fail check below. Please fix any issues that cause CircleCI to fail or ask for clarification--we try, but sometimes the errors can be unclear.
A maintainer will try to respond within 7 days. If you haven’t heard anything by then, please bump this thread. To ensure codebase quality, large code line changes may take more than 2 weeks to review, but may take longer depending on the number of pull requests in the queue. Feel free to ask for a status update at any time--you won't be bothering anyone.
Once feedback has been given, please reply to the feedback giver once the feedback on been addressed, so that they can continue the review.
If you need a release while you are waiting for a code review, you can publish a built tag to your own fork. See directions in the release README.

@lkretzschmar lkretzschmar changed the title Nanoid for shortid Replace shortid with nanoid Nov 17, 2023
@interactivellama
Copy link
Contributor

Hi, I was able to look into this over the end-of-year break from work. I have no concerns with the codebase updates--however nanoid has been giving me a little trouble.

I have the Karma/Mocha unit tests working now in this PR which is a merge with master after a recent commit.
#3136

However the nanoid module is causes Jest to crash. Based on the error below in my PR's CI logs:

 /home/circleci/project/node_modules/nanoid/index.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){import { webcrypto as crypto } from 'node:crypto'

the issue appears to be nanoid's browser crypto API not working in Jest which requires an update to Jest 29 according to Jest docs.
https://jestjs.io/docs/upgrading-to-jest29#jsdom-upgrade

I'll keep looking into this, but I wanted to update you with the status of the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shortid is deprecated
2 participants
@lkretzschmar @interactivellama