Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade VideoJS to 8.0 or latest stable version #401

Open
3 of 5 tasks
Dananji opened this issue Feb 9, 2024 · 5 comments
Open
3 of 5 tasks

Upgrade VideoJS to 8.0 or latest stable version #401

Dananji opened this issue Feb 9, 2024 · 5 comments
Assignees

Comments

@Dananji
Copy link
Collaborator

Dananji commented Feb 9, 2024

Description

Video.js version in Ramp has been pinned to 7.* because it needed Video.js to be that version to use the quality selector plugin used in Ramp.
Ramp was waiting on silvermine/videojs-quality-selector#93 to be merged and released to upgrade Video.js. Now that it has been merged and released @silvermine/videojs-quality-selector can be upgraded from 1.2.4 to 1.3.1 which is the latest version of the plugin. And subsequently Video.js can be upgraded from 7.* to 8.*

Done Looks Like

  • @silvermine/videojs-quality-selector upgraded to 1.3.1
  • videoj.js upgraded to latest stable 8.* version
  • VideoJSFileDownload component's code changes to use extends instead of videojs.extend(..
  • Test all the custom VideoJS components (Progressbar, previous/next buttons, current time display, trackscrubber, file download) works as expected in all supported browsers and devices
  • Test all the other customization Ramp has implemented on top of native VideoJS functionalities work as expected in all supported browsers and devices
@joncameron
Copy link
Contributor

This can be worked on after 7.7 release; will require a retest across media player test cases since this will be a large change.

@joncameron
Copy link
Contributor

Most of the work here will be testing; custom components should all be tested for functionality.

@joncameron
Copy link
Contributor

Wait to merge for a new Ramp until 3.0.1 release.

@Dananji
Copy link
Collaborator Author

Dananji commented Apr 22, 2024

This work has been deployed to Ramp demo site

@joncameron
Copy link
Contributor

Need to update test cases in Testomat.io to make sure all of the areas mentioned in this ticket are represented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants