Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the yarn link approach from importing browse-everything-react into .internal_test_app #330

Open
jrgriffiniii opened this issue Feb 21, 2020 · 0 comments

Comments

@jrgriffiniii
Copy link
Contributor

The approach should instead automate the following tasks:

export BE_REACT_BRANCH=master # Or, some other branch
export BE_REACT_URL=https://github.com/samvera-labs/browse-everything-redux-react.git  # Or, some fork
cd .internal_test_app/node_modules
rm -fr browse-everything-react
git clone -b $BE_REACT_BRANCH $BE_REACT_URL
cd ../..
ln -s .internal_test_app/node_modules/browse-everything-react

This seems to be the only stable way of offering an integrated development environment. The documentation will obviously need to be updated with this as well.

@jrgriffiniii jrgriffiniii added this to the 2.0.0.rc1 milestone Feb 21, 2020
@jrgriffiniii jrgriffiniii added this to To do in BrowseEverything 2.0.0 Release via automation Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

1 participant