Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a DATABASE_URL environment variable in the Postgres executor #42

Open
rotated8 opened this issue Jul 10, 2020 · 1 comment
Open

Provide a DATABASE_URL environment variable in the Postgres executor #42

rotated8 opened this issue Jul 10, 2020 · 1 comment

Comments

@rotated8
Copy link
Contributor

The orb should own the specifics of creating a URL for the database it provides. This would help with samvera/hyrax#4397, and other postgres-using implementors.
@rotated8 rotated8 mentioned this issue Jul 10, 2020
Merged
@jeremyf
Copy link

jeremyf commented Jul 13, 2020

I think for backwards compatability, you could export both DATABASE_URL and the DATABASE_NAME and DATABASE_USER

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
samvera-circleci-orb
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeremyf @rotated8