Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - Renaming docs for "components" to "fragments" #445

Open
rtablada opened this issue Feb 7, 2019 · 1 comment
Open

Docs - Renaming docs for "components" to "fragments" #445

rtablada opened this issue Feb 7, 2019 · 1 comment

Comments

@rtablada
Copy link
Contributor

rtablada commented Feb 7, 2019

Currently in the docs there is a section for "Components" which is confusing when someone may be looking for how to test @ember/components in their application. It think it would make sense to rename this section to fragments or maybe "organizing and sharing functionality".

The emphasis for this is because with the addition of #444 and documentation around it would add official docs for how to use this addon in integration tests to test actual Ember Components which then would cause confusion between the current section (which is more about organization) vs the integration test usage.

@ro0gr
Copy link
Collaborator

ro0gr commented Feb 28, 2019

I think it's more about "definitions". components are page object instances while defs aren't.

I like the fragments name. However, I think they should provide a way to compose an instance from multiple fragments with a well specified merge behavior.

The best we currently can do with definitions is:

const i = create(
  Object.assign({}, def1, def2, {
    scope
  })
);

which is far from being ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants