Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala-concurrent-tck runs long #864

Open
lrytz opened this issue Mar 27, 2024 · 2 comments · May be fixed by scala/scala#10732
Open

scala-concurrent-tck runs long #864

lrytz opened this issue Mar 27, 2024 · 2 comments · May be fixed by scala/scala#10732

Comments

@lrytz
Copy link
Member

lrytz commented Mar 27, 2024

2.13.x, on my M1:

ok 1 - jvm/scala-concurrent-tck.scala          [duration 68.95s]

Credits to @Duhemm and Gradle's Develocity :)

Some recent PRs around that test

where I find "duration 6.85s" and "it takes about 13 seconds", so maybe something has changed in the meantime.

@som-snytt
Copy link

som-snytt commented Mar 27, 2024

It says, ominously, "I might have to up my Klang level."

finished testUncaughtExceptionReporting 5401539741146 after 62135 ms

The test change and scala/bug#12902 were both 2.13.7. I happened to look at that ticket recently.

I cherry-picked the test onto 2.13.6 and it is still long, so it must be broken. I'll see about fixing it.

Edit: first run this morning was normal, i.e., fast. This was the test which wanted to wait for the pool thread to terminate, to ensure that it would not spuriously report an error. So the test waits on its keepAlive, which is configurable in JDK 9 (as a constructor parameter only) and defaults to 60 sec. Maybe the test can use a regular thread pool executor instead.

@som-snytt
Copy link

The PR tries to create a pool with short keep-alive, but now I wonder if it's possible to engineer the test so that it would run on a thread whose keep-alive is just expiring. That would involve scheduling a minute of other tests ahead of it. Note that the long wall-clock time of the test was relatively benign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants