Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala.js 1.0 support seems broken #2051

Open
exoego opened this issue May 25, 2020 · 2 comments
Open

Scala.js 1.0 support seems broken #2051

exoego opened this issue May 25, 2020 · 2 comments

Comments

@exoego
Copy link
Contributor

exoego commented May 25, 2020

scalameta 4.3.12, with Scala.js 1.0 support, seems broken on Scala.js 1.0 project while running test:

See https://travis-ci.com/github/exoego/scalajs-util-types/jobs/339579547#L441

/home/travis/build/exoego/scalajs-util-types/macros/target/scala-2.12/macros-test-fastopt.js:1
let parseSource,default,parseStat;
                ^^^^^^^

It seems that Scala.js 1.0 generates JavaScript with a variable named default , which is keyword in ECMAScript 2015.

@exoego exoego changed the title Scala.js 1.0 support is broken Scala.js 1.0 support seems broken May 25, 2020
@olafurpg
Copy link
Member

Thank you for reporting! Can we work around this by changing the exported name?

@exoego
Copy link
Contributor Author

exoego commented May 25, 2020

If the project is configured as JS module, the error will be gone.
https://www.scala-js.org/doc/project/module.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants