New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with rolling your own request matcher #86

Open

xocasdashdash opened this issue Jul 11, 2015 · 0 comments

xocasdashdash commented Jul 11, 2015

Hi!
I had to roll my own request matcher service in my firewall and I had to implement an RequestMatcherInterface (https://github.com/symfony/HttpFoundation/blob/master/RequestMatcherInterface.php).

Now because of this file: https://github.com/schmittjoh/JMSDebuggingBundle/blob/430daab75b88d78ee9e06ed2ae7811ea3da947af/Security/TraceableMap.php (line 29) is expecting the request matcher to be one of this type https://github.com/schmittjoh/JMSDebuggingBundle/blob/430daab75b88d78ee9e06ed2ae7811ea3da947af/HttpFoundation/TraceableRequestMatcher.php

I had to implement two methods that are not present on the RequestMatcherInterface.php.

Are you open to a PR that makes this method optional so it plays well with user defined Request Matcher?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment