Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TB2::Counter #119

Closed
schwern opened this issue Jan 24, 2011 · 0 comments
Closed

Remove TB2::Counter #119

schwern opened this issue Jan 24, 2011 · 0 comments
Assignees
@schwern
Labels
DO IT Gardening Test-Builder2
Milestone
Test::Builder1.5 ...

Comments

@schwern
Copy link
Contributor

schwern commented Jan 24, 2011

Every formatter gets every event, so there's no need for a shared counter object. An integer will do fine as part of the History object.

There's some complications in Test::Builder because it expects the TAP formatter to retain the count, it being mostly a TAP thing. I'd rather the counter was handled by history, it can't hurt and it removes a special case from the TAP formatter.
@ghost ghost assigned schwern Mar 31, 2012
schwern added a commit that referenced this issue Mar 31, 2012
@schwern
Replace TB2::Counter with a simple integer.
4aeca96 
TB2::Counter is a relic from back when the counter was going to be shared amongst
many builders.  Now we have TB2::History for that.

For #119
@schwern schwern closed this as completed Mar 31, 2012
@schwernbot schwernbot mentioned this issue Mar 16, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schwern schwern

Labels
DO IT Gardening Test-Builder2
Projects
None yet
Milestone
Test::Builder1.5 stable release
Development

No branches or pull requests
1 participant
@schwern