Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give everything an object ID #162

Closed
schwern opened this issue Nov 2, 2011 · 4 comments
Closed

Give everything an object ID #162

schwern opened this issue Nov 2, 2011 · 4 comments

Comments

@schwern
Copy link
Contributor

schwern commented Nov 2, 2011

It will be very useful for everything to have an object ID.

Extract event_id from Test::Builder2::Event, turn it into a role, call the new attribute object_id and add it to Event, EventWatcher, EventCoordinator, Test::Builder and Test::Builder2.

@lecstor
Copy link

lecstor commented Nov 17, 2011

should this be using a uuid? if so, does it need to we need to "internalise" the code?

@schwern
Copy link
Contributor Author

schwern commented Nov 18, 2011

No, a uuid would be overkill. It just has to be unique within the process and predictability is not a concern. Just make it clear in the docs that the ID is easily predictable.

It can be made something strong later if we find it's necessary.

@lecstor
Copy link

lecstor commented Nov 24, 2011

having a crack at this..

lecstor added a commit to lecstor/test-more that referenced this issue Nov 30, 2011
- created a new role HasObjectID using the event_id method from Test::Builder2::Event as method object_id.
- added HasObjectID to Event, EventHandler, EventCoordinator, Test::Builder, and Test::Builder2

For Test-More#162
lecstor added a commit to lecstor/test-more that referenced this issue Nov 30, 2011
- added object_id docs to consuming classes
- created a test for TB2::Formatter testing object_id
- added object_id test to History/History.t

For Test-More#162
lecstor added a commit to lecstor/test-more that referenced this issue Nov 30, 2011
- added object_id docs to consuming classes that missd out last time.
- gave TestState it's own object_id

For Test-More#162
@schwern
Copy link
Contributor Author

schwern commented Dec 6, 2011

@lecstor Cool, that'll do it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants