Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write a TAP legacy formatter. #215

Closed
schwern opened this issue Nov 16, 2011 · 1 comment
Closed

Write a TAP legacy formatter. #215

schwern opened this issue Nov 16, 2011 · 1 comment
Assignees
@schwern
Labels
Blocking Stable DO IT Formatter Test-Builder2
Milestone
Legacy format com...

Comments

@schwern
Copy link
Contributor

schwern commented Nov 16, 2011

The TAP v13 formatter contains a lot of improvements. Unfortunately, a lot of CPAN module tests look at the exact output of Test::Builder. They'll break.

One way to to fix this is to have a legacy TAP formatter, we'll call it TAP::TB1, which outputs just like Test::Builder 0.x does. Then test suites can use it. Test::Builder::Tester can also default to it.

Your task is to write this.

That's off the top of my head.

Since most of the differences are strings embedded in complicated logic, a good solution would be to turn those strings into configurable attributes. Then have the TB1 formatter use different defaults.
#219 should be done first.
@schwern schwern mentioned this issue Nov 20, 2011
Closed
@schwern schwern mentioned this issue Nov 30, 2011
Closed
@ghost ghost assigned schwern Nov 30, 2011
schwern added a commit that referenced this issue Nov 30, 2011
@schwern
First pass at the TB1 TAP formatter.
c911851 
* Make the ending commentary dynamic in TAP::Base.
* Make the directive label dynamic.

The exit code commentary is still in Test::Builder, not in the formatter.  I don't think
that's critical, I doubt most tests were relying on that.

For #215
schwern added a commit that referenced this issue Nov 30, 2011
@schwern
Add show_empty_result_names to control how ok( 1, "" ) comes out.
1f409fd 
For #215 #84
schwern added a commit that referenced this issue Nov 30, 2011
@schwern
Test the TAP::TB1 formatter.
e821960 
For #215
@schwern
Copy link
Contributor Author

schwern commented Nov 30, 2011

There's probably other issues, but it will shake out as we test it against CPAN modules.

@schwern schwern closed this as completed Nov 30, 2011
@schwern schwern mentioned this issue Feb 18, 2012
Closed
@schwernbot schwernbot mentioned this issue Mar 16, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schwern schwern

Labels
Blocking Stable DO IT Formatter Test-Builder2
Projects
None yet
Milestone
Legacy format compatibility
Development

No branches or pull requests
1 participant
@schwern