Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easy to change the formatter from inside the test. #243

Closed
schwern opened this issue Nov 30, 2011 · 1 comment
Closed

Make it easy to change the formatter from inside the test. #243

schwern opened this issue Nov 30, 2011 · 1 comment
Assignees
@schwern
Labels
DO IT Easy Formatter Test-Builder2
Milestone
Legacy format com...

Comments

@schwern
Copy link
Contributor

schwern commented Nov 30, 2011

I see two ways of doing this.

  • A Test::Builder method which clears the formatters and adds a new one. change_formatter()?
  • Change Test::Builder::Module->import so it understands a "formatter" option.

The former is the most flexible, and easier than the user having to clear and set the formatter in two steps. The latter allows use Test::More formatter => TB2::Formatter::POSIX but it will work for any module derived from Test::Builder::Module.

Implement both.
@ghost ghost assigned schwern Dec 6, 2011
schwern added a commit that referenced this issue Mar 22, 2012
@schwern
Write set_formatter() to provide a way for a user to easily change th…
0d98958 
…e formatter.

For #243

Decided with set_formatter() instead of change_formatter() because "set" is the usual
accompaniment to a getter.

Also documented test_state and formatter.
schwern added a commit that referenced this issue Mar 22, 2012
@schwern
Move Test::Builder::Module tests into their own subdir.
0ae9d27 
In prep for there being more TBM tests.

For #243
schwern added a commit that referenced this issue Mar 22, 2012
@schwern
Add a "formatter" option to the Test::Builder::Module.
0af116d 
Let's users easily change the formatter at the individual test level.

For #243
@schwern
Copy link
Contributor Author

schwern commented Mar 22, 2012

done.

@schwern schwern closed this as completed Mar 22, 2012
@schwernbot schwernbot mentioned this issue Mar 16, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schwern schwern

Labels
DO IT Easy Formatter Test-Builder2
Projects
None yet
Milestone
Legacy format compatibility
Development

No branches or pull requests
1 participant
@schwern