Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing random state in Quantile Regression #405

Open
gmartinonQM opened this issue Jan 25, 2024 · 1 comment · May be fixed by #424
Open

Missing random state in Quantile Regression #405

gmartinonQM opened this issue Jan 25, 2024 · 1 comment · May be fixed by #424
Assignees
@LacombeLouis @thibaultcordier
Labels
bug Something isn't working developers Proposed by developers. good first issue Good for newcomers
Projects
Developments

Comments

@gmartinonQM
Copy link
Contributor

I am trying to get reproducible results with MapieQuantileRegressor with the "split" method. Unfortunately :

TypeError: MapieQuantileRegressor.__init__() got an unexpected keyword argument 'random_state'

Whereas the attribute random_state is indeed used in the code of MapieQuantileRegressor, but always with the default value None. (

MAPIE/mapie/regression/quantile_regression.py

Line 391 in 2681b82

random_state=random_state,
)

Could you please add the random_state in the constructor of MapieQuantileRegressor ?
@gmartinonQM gmartinonQM added the enhancement New feature or request label Jan 25, 2024
@LacombeLouis
Copy link
Collaborator

Hi @gmartinonQM, thank you for this information.
If you want replicable results for the moment, I would suggest using the random_state in the .fit method. However, this is indeed something we should change to have it in the .__init__() of the method.
Thank you!

@LacombeLouis LacombeLouis added bug Something isn't working good first issue Good for newcomers and removed enhancement New feature or request labels Jan 26, 2024
@LacombeLouis LacombeLouis added this to Need triage in Developments via automation Jan 26, 2024
@LacombeLouis LacombeLouis moved this from Need triage to Bugs to be fixed (Low Priority) in Developments Jan 26, 2024
@thibaultcordier thibaultcordier added the developers Proposed by developers. label Mar 1, 2024
@tiagoleonmelo tiagoleonmelo linked a pull request Mar 22, 2024 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LacombeLouis LacombeLouis

@thibaultcordier thibaultcordier

Labels
bug Something isn't working developers Proposed by developers. good first issue Good for newcomers
Projects
Developments
Bugs to be fixed (Low Priority)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add random state to MapieQuantileRegressor constructor tiagoleonmelo/MAPIE
3 participants
@gmartinonQM @LacombeLouis @thibaultcordier