Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time for the annual 0.20 release? #1471

Closed
evelikov opened this issue Nov 13, 2021 · 65 comments
Closed

Time for the annual 0.20 release? #1471

evelikov opened this issue Nov 13, 2021 · 65 comments

Comments

@evelikov
Copy link
Contributor

Looking at the past few releases - looks like sddm is having one roughly every year. With the last one in Nov 2020.

At the same time the 0.20.0 milestone tracker lists 11 outstanding and 42 addressed issues. Handful of the outstanding ones are fairly old (2015, 2017 anyone) and there is seemingly no traction there.

So my question is - would it make sense to trim down the milestone to regressions and other issues actively being worked on? This way we can get a release out sooner, so people can enjoy features like rootless X sooner than later?

@plfiorini what do you think?

@aleixpol
Copy link
Contributor

At the very least we'd need to merge this first: #1460

And I've been trying to stress test it but I'd appreciate it if the rest of you also did a round as well, as a lot of components have changed since the last stable release.

@smirkybg
Copy link

Now that #1460 appears to be merged, is there anything else holding back the next release, besides stress testing?

@ReillyBrogan
Copy link

ReillyBrogan commented Dec 15, 2021

I've noticed a regression on Solus Linux between 0.19.0 and git master where if PAM fails (such as the user entering an incorrect password) then the user is left at blank screen without any feedback on what went wrong or any ability to go back to the login screen (the user must switch to a TTY in order to restart SDDM). Has anyone else noticed this?

@ReillyBrogan
Copy link

I went ahead and bisected this and it looks like it broke in commit d46ad35. Based on what that commit does I assume the issue is that the greeter is being stopped before authentication finishes and is thus not able to catch the failed authentication?

Ping @aleixpol as the author of said commit.

@aleixpol
Copy link
Contributor

I went ahead and bisected this and it looks like it broke in commit d46ad35. Based on what that commit does I assume the issue is that the greeter is being stopped before authentication finishes and is thus not able to catch the failed authentication?

#1484

Please next time create a separate issue, it makes it easier to track these things. Thanks a lot for the research though, it made the fixing much easier.

@issue-dispenser
Copy link

Any chance for a new version in time for Plasma 5.24?

@Izaic
Copy link

Izaic commented Apr 16, 2022

Seems that's a nope... Hopefully 5.25!

@ghost
Copy link

ghost commented Apr 30, 2022

When is the rootless Xorg and Wayland release?

@RarogCmex
Copy link

RarogCmex commented Jun 22, 2022

@Izaic
Seems that's a nope... Hopefully 5.25!

5.25.1 is here. I want to say something sarcastic. You're guys doing the great job.

@MenacingPerson
Copy link

Seems that's a nope... Hopefully 5.26!

@fat0troll
Copy link

Seems that's a nope... Hopefully 5.27!

lol

@MenacingPerson
Copy link

Year of the SDDM release?

@RarogCmex
Copy link

RarogCmex commented Oct 14, 2022 via email

@ghost
Copy link

ghost commented Nov 3, 2022

GDM is a great alternative

@herostrat
Copy link
Contributor

herostrat commented Nov 18, 2022

Dublicates: #1579 #1549
A lot of issues in the tracker would also be fixed

@aleixpol @plfiorini @davidedmundson can you give any timeline or name the showstopper petty please
It would help tremendously for stability!

Edit: Would it help you if I write a Github Action that can automate the release and upload of artifacts?

@aleixpol
Copy link
Contributor

I think we are ready for a release, @plfiorini what do you think?

@SebTM
Copy link

SebTM commented Nov 25, 2022

I think we are ready for a release, @plfiorini what do you think?

Would appreciate it as it should introduce running SDDM on Wayland (#1393), right? :)

@arrowd
Copy link
Contributor

arrowd commented Nov 27, 2022

It'd be great to include this PR in the release: #1622

@Nexxkinn
Copy link

Any updates?

Fedora is planning to switch the greeter to wayland by default on Fedora 38 with next February as the deadline.

https://fedoraproject.org/wiki/Changes/WaylandByDefaultForSDDM
https://fedorapeople.org/groups/schedule/f-38/f-38-key-tasks.html

@kojq
Copy link

kojq commented Jan 1, 2023

QML based X11 and Wayland display manager

Sounds like a solid resolution for the New Year 👌

@rottenpants466
Copy link
Contributor

Any updates?

@herostrat
Copy link
Contributor

I know this is a project of people investing their free time and ressources into.
I also know that perpetual nagging is not really helpful, as you as devs get fed up - more so as you gain litte to nothing in return.

So let me say: thank you for sddm. It really is not taken for granted that you provide us with this awesome piece of software.

(And here comes the) But as it is really popular, used in KDE and is like the first interaction one gets with the system. It is very important from a usability and security point of view.

Imho development here stalled. I understand that everyone can do in their free time whatever they want to do. I know it sounds hollow to neg because we could stand up and do the work instead of crying.
I am neither skilled nor motivated enough to do this.

Is it possible to shelter this project under the KDE umbrella? There are a lot more active people and with a planned release cycle. So fixes get shipped timely. PR get a chance to be reviewed and merged.

Please - I know I am not entitled to anything - consider reactivating this project. And be it by accepting that one has no interest in maintaining anymore.

A very grateful user

@plfiorini
Copy link
Member

Moving the project under the KDE umbrella wouldn't gain much because all the relevant KDE developers interested are here and have commit rights and can give other people those rights.

Maybe a company can sponsor the development? That would motivate and push me to review some PRs and get back to SDDM hacking.

@bkchr
Copy link

bkchr commented Jan 21, 2023

@plfiorini maybe you would be open to accept sponsoring via github? I would like to sponsor you if you are open for it :)

@herostrat
Copy link
Contributor

Moving the project under the KDE umbrella wouldn't gain much because all the relevant KDE developers interested are here and have commit rights and can give other people those rights.

Maybe a company can sponsor the development? That would motivate and push me to review some PRs and get back to SDDM hacking.

I hope it is possible to generate income from this. For what it is worth, I think if you really want to make it work you should start patreon/github sponsor/etc and most importantly advertise it as much as possible.

Regarding the gain of KDEs umbrella I disagree.
There are two distinct problems here:

  1. Releasing new version regulary. With KDEs release management it would help tremendously. Even if each version only ship little fixes or one feature, better it ships at all than every couple years.

  2. Development slow/PR have slow review process. Imho this would not be much different, but who knows. Shipping features regulary motivates interaction and participation. At least in my experience.

Please note I am no KDE dev and everything is only my opinion. I cannot stress enough that I do not want to provocate or put anybody off. Just thinking out loud as the status quo is unsatisfactory imo.

@aleixpol Just food for thought

@aleixpol
Copy link
Contributor

aleixpol commented Feb 1, 2023

Moving the project under the KDE umbrella

Feel free to create separate issues both for code location and coordination and also for fundraising. There might be opportunities but I doubt they're huge. As an SDDM dev, I think we'd gain most by adopting certain dependencies to KDE software than by relocating, although I agree that there's always benefits in closely collaborating with a bigger project like KDE.

With regards to the issue at hand, I've found some time to fix some leftover issues I knew were present in our implementation. I'd like to encourage testing of current develop branch and if there are no regressions I'd move forward and get a much needed release out.

@ghost
Copy link

ghost commented Feb 14, 2023

3 years and no release. I would love to see an alternative that integrates with KDE wallet

@C0rn3j
Copy link
Contributor

C0rn3j commented Mar 6, 2023

@SingYankee 2.5 years even, but spamming email of 20+ people isn't going to help push things forward.

@MenacingPerson
Copy link

Why don't SDDM devs just release right now? Screw the regressions, isn't that what point releases are for? The master branch works way better than the normal release anyway.

@farline99
Copy link

Yes, I think the same. People not using Arch should suffer. Release a version and forget about the problem. Otherwise, everyone will be just as bad for a long time :(

@damentz
Copy link

damentz commented Mar 11, 2023

I'm probably not helping by adding to the spam here, but maybe SDDM should switch a versionless update model? Rather than seeking perfection by resolving all regressions before tagging, put the onus on the distributions to apply patches or reverts as needed to get the desired behavior on their end.

This might sounds like a bad idea at first take, but it's clear to me the maintainers of the major distributions have more time to get things right than the developers. Given the resource differential, I don't see a problem with a change like this. It will also clear up what distributions should be chasing, latest master/develop or the latest tag of the repository.

I'm personally using sddm-git from the Arch AUR and update it periodically on all my systems. It fixes some odd lingering bugs that have been fixed for literally years. If things don't change in the next year, I'm assuming most distributions will also begin probably consider just following the develop branch and ignore any "releases" that come out anyways.

@farline99
Copy link

Fedora already does this. It uses git-hash version model specificaly for SDDM because (i think) of Wayland Default SDDM initiative =)

@Vogtinator
Copy link
Contributor

I would assume that most (hopefully all) distros which ship 0.20.0 don't just build it vanilla but apply fixes on top.

@ReillyBrogan
Copy link

I would assume that most (hopefully all) distros which ship 0.20.0 don't just build it vanilla but apply fixes on top.

I think at least one patch is required if you don't want the XDG to crashloop on login. There's a couple of build fixes that are probably required too depending on the versions of other things.

@darkbasic
Copy link

put the onus on the distributions

That's a terrible idea. It's what distributions do on the worst case scenario but if every project did that it would be a nightmare for distros. If git master + a couple of patches is better than stable releases (and it really is in the case of sddm) then upstream should take courage and do the only sane thing to do: release a new version despite the known issues.
There are some libraries that I use in my applications where the upstream keeps developing the thing but latest stable release is basically unusable and years old: it makes no sense that users end up forking the project to release their own "stable" versions (which the majority of users end up using) and still upstream refuses to release.

@Vogtinator
Copy link
Contributor

That's a terrible idea. It's what distributions do on the worst case scenario but if every project did that it would be a nightmare for distros. If git master + a couple of patches is better than stable releases (and it really is in the case of sddm) then upstream should take courage and do the only sane thing to do: release a new version despite the known issues.

We'd need a 0.20.1 for that, but so far SDDM didn't put in the effort to maintain stable branches. Then the issue is that some actually want features and not just bugfixes...

@darkbasic
Copy link

darkbasic commented Mar 11, 2023

We'd need a 0.20.1 for that, but so far SDDM didn't put in the effort to maintain stable branches.

Dealing with stable branches is not hard when you don't have to offer any kind of long term support. On the contrary you can branch just to backport a couple of fixes later.

Then the issue is that some actually want features and not just bugfixes...

That's because these features have been laying in the main branch for years: it's frustrating and understandable.
That's also one of the reasons why I use Gentoo on my desktop computer: I am basically the maintainer of my own distro and I can do whatever I want even when maintainers don't want to upstream patches or don't release often enough.

@Yuri-K7
Copy link

Yuri-K7 commented Mar 13, 2023

Then the issue is that some actually want features and not just bugfixes...

So sddm hanging 1m30s when shutting down and not seeing sddm when booting with 2 monitors are features now

@polarathene
Copy link

polarathene commented Mar 13, 2023

sddm hanging 1m30s when shutting down

$ pacman -Q | grep sddm

sddm 0.19.0-9
sddm-kcm 5.27.2-1

I haven't had that shutdown issue in 1-2 years, it's not sddm AFAIK.

I am running EndeavourOS with X11. Perhaps your distro has older packages that aren't sddm that causes that issue for you? (or it applies patches that contribute to the problem). I know the delay is a systemd default, and I recall something related to that changing a while back.

An older install may also have the latest updates, but left original config alone (this can happen with packages installed too IIRC). A good example might be when Plasma changed to systemd boot service, maybe that's what resolved it for me and for you on an existing install you were not switched after the update?

EDIT: Usually if you experience a bug, you should report that, and if you're going to cite it in an issue like this, then link to that report. If you searched Github Issues (or the KDE bugzilla), you'd find this is already done with plenty of users chiming in. They share workarounds (systemd config to lower the time), others use sddm-git, or have found the Plasma systemd boot works for them.

not seeing sddm when booting with 2 monitors are features now

I run with two monitors as well, although I have autologin enabled so I can't comment on that much. Both displays seem to handle boot to desktop just fine though.

NOTE: If you want to discuss this further, ping me from an appropriate issue, not this one.


Anyway, I have been getting a tonne of notifications on this issue recently but often it's nothing regarding progress, or contributing anything of value to the issue as an update.

The repo continues to see active development (frequent commits). Yes a proper release would be great, but all you're doing adding another comment here that doesn't add value and annoys many that are subscribed.

👍 the issue description at the top, click "subscribe" on the right, and then wait with everyone else or get involved with development to resolve it sooner.

If your comment doesn't add value (complaining it's not released, asking if there are any updates when the issue is open and no new release, etc), please stop. Take that to a community discussion instead, not an issue tracker.

@Yuri-K7
Copy link

Yuri-K7 commented Mar 13, 2023

I know all this, that's why I switched to sddm-git, but checking again and it seems my 2 monitors problem isn't actually fixed so I'll open an issue.

@Vogtinator
Copy link
Contributor

Then the issue is that some actually want features and not just bugfixes...

So sddm hanging 1m30s when shutting down and not seeing sddm when booting with 2 monitors are features now

No. But rootless X or wayland greeters are.

@hch12907
Copy link

I know "pls make a new release" is annoying and I apologize for it, but is it possible to make a 0.19.1 release that includes a fix for the 90-second-shutdown bug?

I am currently working around this by installing sddm-git using AUR but now that I see someone else (who is less tech-savvy than me and not an Arch user) suffering from the same bug, I really think that it's overall better for everyone to make a small release.

@Vogtinator
Copy link
Contributor

I know "pls make a new release" is annoying and I apologize for it, but is it possible to make a 0.19.1 release that includes a fix for the 90-second-shutdown bug?

Do you know which commit fixed that?

@C0rn3j
Copy link
Contributor

C0rn3j commented Mar 25, 2023

@Vogtinator #1476 (comment)

I suppose this is it.

@qoijjj
Copy link

qoijjj commented May 20, 2023

The 1.5 year existence of this thread is indicative that this project could use an additional maintainer dedicated solely to handling interim releases. This would free up the existing maintainers to focus on the next generation of sddm and reviewing pull requests, while also releasing bugfixes. It's abnormal to treat this as an "either or". There are several sddm bugfixes, like the one mentioned above, that are already merged. We need a dedicated maintainer to handle bugfix releases. I would be happy to take this on, but I doubt I'm the best candidate. In any case whether it's me or someone else, that role needs to be filled as this isn't just about 19.1, it's about 19.2, 19.3, 20.1, etc.

@nairaner
Copy link

SDDM is approved (at least on the side of KDE) to become part of KDE brand and it should follow more regular release schedule soon.
https://invent.kde.org/plasma/plasma-desktop/-/issues/91

@farline99
Copy link

Oh yeah, such a cool news. SDDM REALLY needs more love and faster releases schedule. Fedora does not suffer from using old SDDM, because it uses git version, but many distros do.

@buhtz
Copy link

buhtz commented May 24, 2023

I also do support the idea to sponsor the current maintainer of sddm and leave the project at itself and don't put it under the organizational KDE umbrella.

I assume that sddm is big and important enough that some donation options (please don't use Microsoft GitHub for that) would make it possible to make a living for one developer.

@darkbasic
Copy link

One does not exclude the other, but honestly the choice of going under the KDE umbrella or not belongs only to Pier Luigi.

@buhtz
Copy link

buhtz commented May 24, 2023

I also wonder if the KDE people still have commit rights in this repo here why they don't commit?

@qoijjj
Copy link

qoijjj commented May 24, 2023

@buhtz

KDE has graciously offered to pull SDDM under its wing. You say you support leaving the project as-is, outside of KDE. And yet you give almost no rationale for why you prefer that.

It's a bit rich to, after 3 years of no releases on this project, hop in and say "did you think about donations?" and not only that but instruct the maintainers on what donation mechanisms they should and shouldn't use. The richness of that aside, your proposal has already not worked for sddm. It's been 3 years since a release. The maintainer mentioned donations already earlier in this thread. It never happened.

Your comments come across as an idealistic imposition of ideology, and not a practical understanding of the current state of sddm. KDE adopting sddm is a breath of fresh air and should be for anyone who's been waiting for an sddm release these past 3 years.

@buhtz
Copy link

buhtz commented May 24, 2023

@buhtz
Your comments come across as an idealistic imposition of ideology, and not a practical understanding of the current state of sddm.

I would say your observation might be correct.

KDE adopting sddm is a breath of fresh air and should be for anyone who's been waiting for an sddm release these past 3 years.

OK, then just asking for my learning because I'm not well experienced with "managing" FOSS projects. Why isn't KDE just forking SDDM? It is GPL software. No need to ask. Just do it.

Or if there are KDE developers with commit rights why don't they (friendly) take over the repo and create a new release?

Or why using SDDM? Why not one of the other alternatives?

I just asking for my learning. ☮️

@qoijjj
Copy link

qoijjj commented May 24, 2023

Why isn't KDE just forking SDDM? It is GPL software. No need to ask. Just do it.

There is no legal requirement to ask, but as a matter of respect for the original maintainer's wishes and as a matter of practicality, it's preferable. For one thing, having a forked version would be a huge drag if commits were still being pushed to the original repo. KDE would spend more time pulling in commits from the old repo than anything else. We're also all working in the same sandbox here. The spirit of the GPL is that we're all collaborating together and sharing our work. Aggressively taking over a project without the maintainer's approval, while permitted by the license, would be both impractical and a violation of the spirit of the GPL.

Or why using SDDM? Why not one of the other alternatives?

SDDM good :) it's also become the defacto standard DM for KDE. There used to be KDM, but now to my knowledge there is no de jure official DM. Adopting SDDM would make what is currently a de facto standard the de jure standard.

@buhtz
Copy link

buhtz commented May 24, 2023

I totally agree with what you wrote about the GPL spirit. I feel it the same way and always try to handle it that way for myself. It always helped me lot with the former maintainers in my back as counsellors for example.

But "3 years no release" sounded to me a bit like "the project is dead" or "no reaction from the maintainer".

@qoijjj
Copy link

qoijjj commented May 24, 2023

But "3 years no release" sounded to me a bit like "the project is dead" or "no reaction from the maintainer".

No release is not the same thing as dead. The last commit to master is from april. No release means that although master has bugfixes for 0.19, there are regressions and new features as well. This complicates things. The codebase has diverged from how it was in 0.19 in a way such that individually cherry-picking those fixes into a separate release at this point wouldn't make a whole lot of sense.

The state of sddm isn't that it's dead, since in terms of contributions it's very much alive. It's moreso that the maintainers lacked bandwidth/funding/interest in maintaining bugfix and point releases. That's completely understandable, but it leaves the project in a state where the release cycle needs to "start over" so to speak. I think KDE can provide the infrastructure and processes to manage release cycles, timeline management, and standardization, while freeing up the maintainers to hack away at sddm :) which is why I'm hopeful that there's agreement from all parties here.

@evelikov
Copy link
Contributor Author

Thanks for the interest and input everyone. I think that we've generated enough noise for developers and maintainers to consider the topic - as indicated by this issue https://invent.kde.org/plasma/plasma-desktop/-/issues/91.

I believe the KDE community will do a great job with project planning/releasing, so I believe we can close this issue.

That said, thank again everyone o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests