Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Elasticsearch 1.3.0 #48

Closed
lukas-vlcek opened this issue Mar 3, 2014 · 7 comments
Closed

Upgrade to Elasticsearch 1.3.0 #48

lukas-vlcek opened this issue Mar 3, 2014 · 7 comments
Assignees
Milestone

Comments

@lukas-vlcek
Copy link
Member

Not urgent but we should do it soon. There were bunch API changes and improvements.

@lukas-vlcek lukas-vlcek changed the title Upgrade to Elasticsearch 1.0.x Upgrade to Elasticsearch 1.x Apr 8, 2014
@lukas-vlcek
Copy link
Member Author

It seems that we might be hitting River does not start #4089 issue while we are on 0.90.5. In particular in our case rivers do not start on multinode cluster when the cluster is restarted (as long as the cluster is single node it is not an issue).
This can be problematic wrt to Searchisko production upgrades. Because of this we should give upgrading to ES 1.x higher priority.

@lkrzyzanek lkrzyzanek added this to the 1.1.0 milestone May 28, 2014
@velias velias removed this from the 1.1.0 milestone May 30, 2014
@lukas-vlcek
Copy link
Member Author

Facets are officially deprecated: elastic/elasticsearch#6485 (starting with ES 1.3)

@velias
Copy link
Member

velias commented Jun 18, 2014

elasticsearch-river-remote, elasticsearch-river-jira and structured-content-tools for ES 1.2.x are available already

@lukas-vlcek
Copy link
Member Author

We also need to keep an eye on changes to CORS support in Elasticsearch (seems most changes are happening from 1.4). Currently CORS is handled partly by Searchisko servlet filter and partly it is delegated to Elasticsearch thus we will be hit by this change.

See: elastic/elasticsearch#6380, elastic/elasticsearch#7151

@unibrew
Copy link
Contributor

unibrew commented Aug 20, 2014

I also vote for 1.4. because then aggregations come to ES and I could find a use for them in my stats APIs implementation.

@lukas-vlcek lukas-vlcek added this to the 1.2.0 milestone Aug 21, 2014
lukas-vlcek added a commit that referenced this issue Aug 22, 2014
All api tests pass.
@lukas-vlcek
Copy link
Member Author

We will be upgrading from Elasticsearch 0.90.5 to 1.x. Official upgrade notes:
http://www.elasticsearch.org/guide/en/elasticsearch/reference/1.x/setup-upgrade.html (note the restart upgrade is recommended).

lukas-vlcek added a commit that referenced this issue Sep 16, 2014
All api tests pass.
lukas-vlcek added a commit that referenced this issue Sep 16, 2014
All api tests pass.
lukas-vlcek added a commit that referenced this issue Sep 16, 2014
All api tests pass.
@lukas-vlcek
Copy link
Member Author

Both api and ftest tests pass.

The following are details about changes in Elasticsearch code that have impact:

ElasticSearchException -> ElasticsearchException

Ticket:
elastic/elasticsearch#4634

setFilter -> setPostFilter

Commit:
elastic/elasticsearch@23d2b1e

Ticket:
elastic/elasticsearch#4119

DeleteResponse.isNotFound() -> DeleteResponse.isFound()

Commits:
elastic/elasticsearch@2cb40fc#diff-12, elastic/elasticsearch@4c06c53

InternalSearchHit changes constructor signature

Commit:
elastic/elasticsearch@668d557#diff-26

(Multi)SearchRequestBuilder does not accept null in constructor

Mocking Client seems to fix it.

Removed ok return value

Impact on integration tests.

Ticket:
elastic/elasticsearch#4310

@lukas-vlcek lukas-vlcek changed the title Upgrade to Elasticsearch 1.x Upgrade to Elasticsearch 1.3.0 Sep 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants