Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure message contain describe text #5

Closed

Conversation

btakita
Copy link

@btakita btakita commented Oct 22, 2010

This was originally http://github.com/seattlerb/minitest/pull/4

I anonimized the Spec classes and overrode .to_s on them to return the given text of the describe argument.

I could also define name= on the class object. That would remove the need to use the (class << self; self; end) closure to define to_s.

The benefit is the error output shows the exact text of the describe blocks. A number of people have naming conventions that use non-alphanumeric characters in the describe text. These characters would be lost with the camel-cased class names.

Do you have any apprehensions against this approach?

Allow describe blocks with the same name to be defined and tested.
@zenspider
Copy link
Collaborator

First, as stated on our user page, we don't use github for anything but mirroring.

Second, your patch doesn't have any tests that actually address this change... There is no obvious point to the addition of 'z' and the naming change isn't tested at all. I'll fix this on my end.

P.S. Please check your editor settings to avoid trailing whitespace.

@minitest minitest locked and limited conversation to collaborators May 17, 2017
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants