Failure message contain describe text #5
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally http://github.com/seattlerb/minitest/pull/4
I anonimized the Spec classes and overrode .to_s on them to return the given text of the describe argument.
I could also define name= on the class object. That would remove the need to use the (class << self; self; end) closure to define to_s.
The benefit is the error output shows the exact text of the describe blocks. A number of people have naming conventions that use non-alphanumeric characters in the describe text. These characters would be lost with the camel-cased class names.
Do you have any apprehensions against this approach?