Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchProducer doesn't check size of payload #48

Open
spenczar opened this issue Nov 11, 2015 · 1 comment
Open

BatchProducer doesn't check size of payload #48

spenczar opened this issue Nov 11, 2015 · 1 comment

Comments

@spenczar
Copy link

Kinesis rejects PutRecords requests over 5 megabytes, but the batch producer doesn't do anything to make sure it doesn't exceed 5 megabytes in its requests.

When this failure is hit, we've seen our batch producer fail entirely as AWS simply kills the HTTP connection. None of the records get through, and every subsequent PutRecords request from the batch producer fails because the batches are too large, and it can't come back by sending smaller payloads.

@le0pard
Copy link
Contributor

le0pard commented Nov 12, 2015

yep, it is reasonable. I wrote before in PRs, what you need itself check size of sending data. But you can send me PR, if you have good idea how to handle this by this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants