Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependency "github.com/go-resty/resty" #4952

Open
Ben131-Go opened this issue Feb 5, 2023 · 0 comments
Open

Upgrade dependency "github.com/go-resty/resty" #4952

Ben131-Go opened this issue Feb 5, 2023 · 0 comments

Comments

@Ben131-Go
Copy link

Background

Repo github.com/sensu/sensu-go depends on github.com/go-resty/resty/v2@v2.5.0.

https://github.com/sensu/sensu-go/blob/main/go.mod#L19

However, comparing version v2.5.0 of github.com/go-resty/resty from proxy.golang.org and github, there are inconsistencies.

commit time of the copy on github.com

"committer": {
      "name": "Jeevanandam M",
      "email": "jeeva@myjeeva.com",
      "date": "2021-02-11T10:21:12Z"
    }

commit time of the copy on proxy.golang.org

{"Version":"v2.5.0","Time":"2021-02-11T09:35:23Z"}

So the checksum from the code in github does not match the checksum saved in sum.golang.org. The v2.5.0 tag of github.com/go-resty/resty might have been retagged after a minor edition on github. I guess you use proxy.golang.org to get dependencies, but that also shows that your project is depending on the copy of github.com/go-resty/resty@v2.5.0 before its edition. Depending upon such inconsistent tag version may also result in some unexpected errors as well as build errors due to different proxy settings.

For example, when someone who does not use proxy.golang.org, say GOPROXY=direct, attempts to get github.com/go-resty/resty/v2@v2.5.0, the following error occurs.

go: downloading github.com/go-resty/resty/v2 v2.5.0
go: github.com/go-resty/resty/v2@v2.5.0: verifying module: checksum mismatch
        downloaded: h1:GmCjQ7qW3Dzr3Lh7FvTrRJSWgYNWswDdOy+T8sgTAFI=
        sum.golang.org: h1:WFb5bD49/85PO7WgAjZ+/TJQ+Ty1XOcWEfD1zIFCM1c=

SECURITY ERROR
This download does NOT match the one reported by the checksum server.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

For more information, see 'go help module-auth'.

So, this is a reminder in the hope that you can get rid of this problematic version of project github.com/go-resty/resty.

Solution

1. Bump the version of dependency github.com/go-resty/resty

I would recommend bumping the version of github.com/go-resty/resty to a new release to ensure dependency copy in proxy.golang.org and github in sync.

References

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant