Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: use configured AWS region instead of "us-east-1" by default #1855

Closed
jokeyrhyme opened this issue Aug 15, 2016 · 10 comments
Closed
Labels
Milestone

Comments

@jokeyrhyme
Copy link

Feature Request:
  • serverless create --template aws-nodejs should be aware of the default region set via aws configure or environment variables
  • currently, it always puts an entry for "us-east-1" in the serverless.env.yml file, instead of something better
  • if all else fails, falling back to the default "us-east-1" would still make sense
Benefits:
  • 1 less thing that a user needs to change
Drawbacks:
  • could be error prone? could be tricky?
@jokeyrhyme
Copy link
Author

Just noticed that region also needs to be properly set in serverless.yml, too.

@jokeyrhyme
Copy link
Author

Even if I change all occurrences of "us-east-1" in all default files to "ap-southeast-2", I still get the following error from serverless deploy:

Region "us-east-1" doesn't exist in stage "dev"

Not sure where this is coming from

@danielkoo
Copy link
Contributor

This is probably the same as what I ran into; if you haven't uncommented the following it would assume the dev stage uses us-east-1:

defaults:
stage: dev
region: ap-southeast-2

@jokeyrhyme
Copy link
Author

I made sure that I uncommented it, but it's possible that I got the indenting wrong or something. I'll give this another try later this week.

@flomotlik
Copy link
Contributor

@danielkoo @jokeyrhyme we're currently changing our stage/region handling and include variables in #1834 and discussed in #1801 . This should sole many of those issues you've just mentioned as we're not going to expect you to set a specific region at all any more by default.

@jokeyrhyme
Copy link
Author

@flomotlik awesome! Thanks! I look forward to giving it a try. I'm really liking everything about Serverless so far. Great work!

@flomotlik
Copy link
Contributor

@jokeyrhyme if you're interested you can absolutely check out the branch and give it a spin. We're looking for feedback on this anyway at the moment before we merge.

@jokeyrhyme
Copy link
Author

I can confirm that it was user error prevention me from explicitly setting the region, previously.

I'll take a look over the next few days to see how the branch improves things, if I can.

@danielkoo
Copy link
Contributor

I'll have a play with the branch as well, cheers @flomotlik

@flomotlik flomotlik modified the milestones: v1.0, v1.0.0-beta.3 Aug 19, 2016
@flomotlik flomotlik added the bug label Aug 19, 2016
@eahefnawy eahefnawy mentioned this issue Aug 31, 2016
8 tasks
@eahefnawy
Copy link
Member

Closing this as it'll be fixed with #1834

Thanks everyone! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants