-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear canvas thread state on recreation. #17609
Conversation
@@ -544,6 +544,8 @@ impl<'a> CanvasPaintThread<'a> { | |||
|
|||
fn recreate(&mut self, size: Size2D<i32>) { | |||
self.drawtarget = CanvasPaintThread::create(size); | |||
self.state = CanvasPaintState::new(self.state.draw_options.antialias == AntialiasMode::Default); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you file a E-Easy
follow-up issue about using AntialiasMode
directly in CanvasPaintState::new
while at it? CanvasPaintState
uses AntialiasMode
too internally, setting the value from the boolean parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #17668.
@bors-servo: r+ |
📌 Commit 0b7a43d has been approved by |
Clear canvas thread state on recreation. <!-- Please describe your changes on the following line: --> The canvas rendering context is cleared when it is recreated, but not the matching state in the canvas paint thread. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #17533 - [X] These changes do not require tests because the css-paint-api tests test for this already. <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17609) <!-- Reviewable:end -->
💔 Test failed - mac-rel-wpt1 |
⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt1... |
☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
The canvas rendering context is cleared when it is recreated, but not the matching state in the canvas paint thread.
./mach build -d
does not report any errors./mach test-tidy
does not report any errorsThis change is