Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly enable EXT_shader_texture_lod #21081

Merged
merged 1 commit into from
Jun 22, 2018
Merged

Properly enable EXT_shader_texture_lod #21081

merged 1 commit into from
Jun 22, 2018

Conversation

nox
Copy link
Contributor

@nox nox commented Jun 22, 2018 •
edited by SimonSapin
Loading

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/script/dom/webgl_extensions/extensions.rs, components/script/dom/webglshader.rs, components/script/dom/webgl_extensions/ext/extshadertexturelod.rs
  • @KiChjang: components/script/dom/webgl_extensions/extensions.rs, components/script/dom/webglshader.rs, components/script/dom/webgl_extensions/ext/extshadertexturelod.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 22, 2018
@highfive
Copy link

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!

emilio
emilio approved these changes Jun 22, 2018
View reviewed changes
Copy link
Member

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but... tests?

@nox
Copy link
Contributor Author

nox commented Jun 22, 2018

The tests already exist, but when the extension doesn't get enabled at all they just pass with "hey you have no support for this extension, which is totally legal". I manually checked that the tests actually pass.

@nox
Copy link
Contributor Author

nox commented Jun 22, 2018

@bors-servo r=emilio

@bors-servo
Copy link
Contributor

📌 Commit 124fe69 has been approved by emilio

@highfive highfive assigned emilio and unassigned avadacatavra Jun 22, 2018
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 22, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit 124fe69 with merge 6a4bd8d...

bors-servo pushed a commit that referenced this pull request Jun 22, 2018
Auto merge of #21081 - servo:lod, r=emilio
6a4bd8d 
Properly enable EXT_shader_texture_lod

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21081)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing 6a4bd8d to master...

@bors-servo bors-servo merged commit 124fe69 into master Jun 22, 2018
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 22, 2018
@bors-servo bors-servo mentioned this pull request Jun 22, 2018
Merged
@SimonSapin SimonSapin deleted the lod branch August 8, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nox @highfive @bors-servo @emilio @avadacatavra