Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove db.getCommittedOpVersion #402

Open
alecgibson opened this issue Nov 11, 2020 · 0 comments
Open

Remove db.getCommittedOpVersion #402

alecgibson opened this issue Nov 11, 2020 · 0 comments
Labels
breaking-change Breaking change that we may want to pull into a future major version

Comments

@alecgibson
Copy link
Collaborator

sharedb-mongo maintains an index against all ops to handle a corner case where we may submit a create op twice: share/sharedb-mongo#94

It would be nice to remove the need for this index, and therefore we'd need to remove the method that relies on it: db.getCommittedOpVersion, which is only used in this one place.
@alecgibson alecgibson added the breaking-change Breaking change that we may want to pull into a future major version label Nov 11, 2020
@alecgibson alecgibson mentioned this issue May 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change Breaking change that we may want to pull into a future major version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alecgibson