New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redrawVueMasonry and imageLoaded Dependency Issues in 0.10.11 #31
Comments
Hello @pingshunhuangalex thanks for your message -
I am using the test repo I've referred in previous issue to check the functionality before releasing new versions. But I would agree to have more integration tests (w different versions / setups) would be a safe measure to not to break things in user's projects |
Hi,
});` became
});` I also thing the beforeDestroy hook in the custom directive is not working. I have to retrigger the redrawVueMasonry function after each v-masonry-tile is detroyed. In the vuejs doc, i can't find any info on such a hook. I tried with update/componentUpdated but it does not seem to work either... Cheers, PS: I quick fixed it for me modifying vueMasonry.js on my side. Can I do something to have a properly built dist ? Ty |
I intend to add a check for imageLoaded asap today. |
I still had a prob so I rolled back to 0.10.9 atm. Thanks for the good work. Cheers |
direct calling
it's my miss that I didn't check that. see example here: https://laracasts.com/discuss/channels/vue/how-to-encapsulate-common-functionality-in-vuejs |
Hi @shershen08 Meanwhile, it'll be nice to have a proper commit message instead of the issue number as GitHub will automatically redirect it to this issue instead of going into the commit itself here Thanks for the fix and keep up the good work. |
Updated a library to 0.10.12 - b55e457 |
After accidentally upgrading it to 0.10.11, I noticed that
this.$redrawVueMasonry()
will trigger the below error in browser's console;I assume this has something to do with the latest merge here #29
Meanwhile, now
Vue-masonry
also seems to requireimageLoaded
as a dependency. Some explanation would be nice here. I would recommend some kind of testing before releasing a new version cuz forvue-masonry
it either works or just breaks the whole website which is rather painful. Thanks.The text was updated successfully, but these errors were encountered: