Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to video exporting #403

Open
stuaxo opened this issue May 19, 2021 · 0 comments
Open

Improvements to video exporting #403

stuaxo opened this issue May 19, 2021 · 0 comments

Comments

@stuaxo
Copy link
Contributor

stuaxo commented May 19, 2021

These are a couple of improvements to video exporting, that we may not have time to do before 1.4

Don't use use shell=True

  • This is a bit of a pain, it's basically passing the command as a list. It makes it much easier later on in Windows, where the shell may never get good at parsing the command line.

  • Move code out of external script and into sbot itself, when called -o and an .mp4 extension.
    This would make things feel much more integrated, but not sure how easy on the current architecture.
    (It may be possible to cheat and call sbot itself in a subprocess).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant