Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected --nx --nz behavior. Ignores interlaced images. #619

Closed
Galaxy4594 opened this issue May 16, 2024 · 1 comment · Fixed by #620
Closed

Unexpected --nx --nz behavior. Ignores interlaced images. #619

Galaxy4594 opened this issue May 16, 2024 · 1 comment · Fixed by #620
Labels
T-Bug Some piece of the software is not working as intended

Comments

@Galaxy4594
Copy link

Galaxy4594 commented May 16, 2024 •
edited

Environment:
Windows 10 22H2

Flags --nx --nz should disable all optimizations for pngs right? It works on all images with one weird exception, interlaced pngs causes oxipng to ignore these flags and optimizes the image anyways.

It seems that the default of -i 0 automatically overrides everything else. It turns out you have to pass --nx --nz -i keep to truly disable all optimizations. The behavior should be so that --nx --nz alone keeps the images untouched regardless of them being interlaced or not.

Screenshot
@andrews05 andrews05 added the T-Bug Some piece of the software is not working as intended label May 16, 2024
@andrews05
Copy link
Collaborator

Hi @Galaxy4594, this is indeed a bug, --nx is supposed to disable the default deinterlacing too. I’ll try to get this fixed sometime.

@andrews05 andrews05 mentioned this issue May 18, 2024
Merged
AlexTMjugador pushed a commit that referenced this issue Jun 2, 2024
@andrews05
Remove default value for interlace to ensure it is kept when nx is us…
e2c5b45 
…ed (#620)

Fixes #619.

Interlacing still defaults to 0 when `--nx` is not specified and can
still be explicitly set even if it is (e.g. `-i 0 --nx` will still
deinterlace).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Bug Some piece of the software is not working as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove default value for interlace to ensure it is kept when nx is used andrews05/oxipng
2 participants
@andrews05 @Galaxy4594